Skip to content

Added compilation instructions for several distros #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pantierra merged 1 commit into from
Aug 3, 2021
Merged

Added compilation instructions for several distros #252

pantierra merged 1 commit into from
Aug 3, 2021

Conversation

@pantierra
Copy link
Collaborator

@pantierra pantierra commented Aug 2, 2021 •
edited
Loading

  • Moved man related docs into docs/man directory.
  • Relied on more consistent name for Ubuntu (20.04 instead of misleading latest).
  • Added compilation instructions for Ubuntu and Fedora and linked them in README.
  • Made centos CI run on the master branch.
  • Additional distros run on a specific distros/NAME branches.

I'd especially appreciate a review by @hummeltech on who's work this is heavily based on.

Closes #232

@pantierra pantierra force-pushed the feature/add-more-documentation-for-compilation branch from c7bf4f2 to 24464c1 Compare August 2, 2021 15:29
@pantierra pantierra mentioned this pull request Aug 2, 2021
Closed
@pantierra pantierra force-pushed the feature/add-more-documentation-for-compilation branch from 24464c1 to ecd1ba5 Compare August 2, 2021 16:15
hummeltech
hummeltech approved these changes Aug 2, 2021
View reviewed changes
Copy link
Collaborator

@hummeltech hummeltech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this looks good, just a few notes. Also a reminder to make sure the debian packaging code takes the change from docs to docs/man into account.

@pantierra pantierra force-pushed the feature/add-more-documentation-for-compilation branch 5 times, most recently from 3f488a0 to 4fd3c23 Compare August 3, 2021 10:51
@pantierra
Copy link
Collaborator Author

pantierra commented Aug 3, 2021 •
edited
Loading

Rebased on latest master which includes #253

hummeltech
hummeltech reviewed Aug 3, 2021
View reviewed changes
hummeltech
hummeltech reviewed Aug 3, 2021
View reviewed changes
Copy link
Collaborator

@hummeltech hummeltech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of option --preserve-env is required so the exported environment variables are available. I.E. LD_LIBRARY_PATH

hummeltech
hummeltech reviewed Aug 3, 2021
View reviewed changes
@pantierra pantierra force-pushed the feature/add-more-documentation-for-compilation branch from 7fe6702 to a1bd7ca Compare August 3, 2021 16:51
@pantierra
Copy link
Collaborator Author

pantierra commented Aug 3, 2021

Thanks a lot for your help and review, @hummeltech!

@pantierra pantierra merged commit c683c55 into master Aug 3, 2021
@pantierra pantierra deleted the feature/add-more-documentation-for-compilation branch August 3, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hummeltech hummeltech hummeltech approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for Fedora and Red Hat

3 participants

@pantierra @hummeltech