Skip to content

fix: connect eventBus block#2844

Closed
piLurk wants to merge 1 commit intomainfrom
feat/feishu-ide
Closed

fix: connect eventBus block#2844
piLurk wants to merge 1 commit intomainfrom
feat/feishu-ide

Conversation

@piLurk
Copy link
Copy Markdown

@piLurk piLurk commented Jun 28, 2023

Types

  • 🐛 Bug Fixes

Background or solution

此 MR 不合入,这是基于 feat/feishu-ide 发布一个 alpha 版本,后续直接关闭

Changelog

🤖 Generated by Copilot at 984e038

Fixed a bug in connection.ts that caused incorrect connection events. Changed the createClientConnection2 function to use reachedAnyState instead of reachedState to handle different states of the stateService.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wudongyue seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


wudongyue seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@opensumi opensumi Bot added 🎨 feature feature required 🐞 bug Something isn't working labels Jun 28, 2023
@piLurk

This comment was marked as outdated.

@bytemain
Copy link
Copy Markdown
Member

/next

@opensumi
Copy link
Copy Markdown
Contributor

opensumi Bot commented Jun 28, 2023

🎉 PR Next version 2.24.6-next-1687921541.0 publish successful! You can install this version via npm install package@2.24.6-next-1687921541.0

2.24.6-next-1687921541.0

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07 ⚠️

Comparison is base (80cd1a5) 57.73% compared to head (984e038) 57.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2844      +/-   ##
==========================================
- Coverage   57.73%   57.66%   -0.07%     
==========================================
  Files        1327     1336       +9     
  Lines       83663    83923     +260     
  Branches    17418    17455      +37     
==========================================
+ Hits        48299    48397      +98     
- Misses      32137    32289     +152     
- Partials     3227     3237      +10     
Flag Coverage Δ
jsdom 52.69% <100.00%> (-0.05%) ⬇️
node 16.78% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/core-browser/src/bootstrap/connection.ts 48.14% <100.00%> (ø)

... and 111 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ricbet
Copy link
Copy Markdown
Member

Ricbet commented Jun 28, 2023

@piLurk 发布测试版本不需要新建 pr,直接通过评论 /next 关键词就行,该 pr 与 #2843 重复了,建议关闭

@bytemain
Copy link
Copy Markdown
Member

如果你们是想维护一个自己的单独分支版本的话,推荐使用一个单独分支来进行跟踪记录,如:feishu/v2.24 这样的分支名

@bytemain bytemain closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working 🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants