Skip to content

Conversation

@sinoon
Copy link
Contributor

@sinoon sinoon commented Jan 23, 2022

Types

  • 🎉 New Features

Background or solution

fixed #357 ,支持枚举配置,以及 default 提示

Changelog

support enumDescriptions on preference view

@sinoon
Copy link
Contributor Author

sinoon commented Jan 23, 2022

image
这是在其他样式下的效果。开天默认主题的 --kt-select-border 变量似乎有点问题,和背景颜色一样了,我还没找到是为啥

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #382 (2f6ba39) into main (c262abb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   59.33%   59.33%           
=======================================
  Files        1189     1189           
  Lines       72861    72861           
  Branches    15085    15085           
=======================================
  Hits        43231    43231           
  Misses      27003    27003           
  Partials     2627     2627           
Impacted Files Coverage Δ
...s/core-common/src/preferences/preference-schema.ts 77.27% <ø> (ø)
packages/i18n/src/common/en-US.lang.ts 100.00% <ø> (ø)
packages/i18n/src/common/zh-CN.lang.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c262abb...2f6ba39. Read the comment docs.

@erha19 erha19 changed the title Add enum support feat: support enumDescriptions on preference view Jan 23, 2022
@sinoon
Copy link
Contributor Author

sinoon commented Jan 24, 2022

@erha19 你提到的点都改了,辛苦再看看 :)

Copy link
Member

@erha19 erha19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

验证通过,待本周迭代版本发布后合并

Copy link
Member

@Aaaaash Aaaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 7921846 into opensumi:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Support enum and enumDescriptions on Preference Settings View

5 participants