Fix some github action warnings: Variables should be defined before their use#136
Merged
Conversation
cgalibern
force-pushed
the
dev1
branch
4 times, most recently
from
6801628 to
28d2f21
Compare
This commit fixes docker build warnings: Variables should be defined before their use It simplifies the docker build process with removing git commands (replaced by env vars) ## README - Add docker build example ## CI Main changes: - Workflow updates (.github/workflows/build-image.yml): - Added a step to set a BUILDTIME environment variable with the current timestamp. - Added a step to set a VERSION environment variable with the current git describe --tags --abbrev. - Passed BRANCH and BUILDTIME as build arguments to the Docker build process. ## Dockerfile updates: - Added a BUILDTIME argument for improved traceability during builds. - Enhanced the git clone command to use the specified branch directly, improving clarity and robustness. - Removed default values for arguments (BRANCH, OSVC_GITREPO_URL) to simplify usage.
…patibility enhancements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.