-
Notifications
You must be signed in to change notification settings - Fork 1
Remove nanoTDF documentation #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @strantalis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant cleanup effort by removing all public-facing documentation and code samples pertaining to the nanoTDF feature. This change reflects the feature's new proprietary status, ensuring that the public documentation accurately represents the available open-source offerings. The updates span across various documentation files, code examples, OpenAPI specifications, and build configurations to eliminate any mention or generation of nanoTDF-related content. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively removes most references to nanoTDF from the documentation, code samples, and build configurations, aligning with the goal of making the feature proprietary. The changes are generally well-executed. However, I've identified a critical issue in one of the Java code samples where a typo was introduced. Additionally, this particular code sample file, being a nanoTDF example, seems to have been overlooked for deletion as per the PR's objective. Please see the specific comment for details.
pflynn-virtru
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
statis/img has newly added nano images
3aa9f93 to
32a3146
Compare
Remove all nanoTDF documentation, code samples, and API spec descriptions as the feature is being made proprietary. This includes the KAS NanoTDF rewrap section, code examples, SDK feature matrix entries, and OpenAPI spec mentions.
32a3146 to
05a88b8
Compare
Remove all nanoTDF references from public documentation and code samples as the feature is being made proprietary.
Changes
Note
OpenAPI specs in
/specsare vendored from upstream. Local modifications will be overwritten when runningnpm run update-vendored-yaml. The upstream opentdf/platform repository should be updated separately.