chore(ci): Adds workflow to bump protocol buffers#243
chore(ci): Adds workflow to bump protocol buffers#243dmihalcik-virtru merged 11 commits intomainfrom
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
.github/workflows/update-platform-branch.yaml:43
- The sed command creates .bak backup files which might be unintentionally committed; consider removing the backup files after modification or adjusting the command to avoid generating backups.
find . -name "pom.xml" -exec sed -i.bak "s|<platform.branch>.*</platform.branch>|<platform.branch>${TAG}</platform.branch>|g" {} \;
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new CI workflow for updating the platform.branch property in pom.xml files and creates a pull request with the changes, while the checks workflow has been updated to reference a new branch.
- Adds update-platform-branch workflow to bump protocol buffers version in pom.xml files.
- Updates the test workflow reference in checks.yaml to the new branch.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/update-platform-branch.yaml | New workflow for updating platform.branch properties and automating PR creation. |
| .github/workflows/checks.yaml | Updated xtest workflow reference to a branch specific to protogen changes. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 2eab556.
elizabethhealy
left a comment
elizabethhealy
left a comment
There was a problem hiding this comment.
other than the above question lgtm
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new GitHub workflow to automatically update the platform.branch property in pom.xml files by bumping the protocol buffer tag.
- Adds a workflow that triggers on schedule, manual dispatch, or via workflow_call.
- Implements steps to fetch the latest protocol/go tag, check for existing PRs, and update or create a PR accordingly.
|
Adds a dependabot-style workflow,
update-platform-branch, which will bump the protocol buffer source tag, used during the generate-sources build phase for RPCs with the policy and key access services.It runs on a schedule to create a dependabot/rennovate style PR, but if you need to bump faster it supports manual dispatch, or, if we get it setup, repository dispatch to make it slightly more automated