Skip to content

Conversation

@jakedoublev
Copy link
Contributor

@jakedoublev jakedoublev commented Oct 9, 2025

  • bump pinned protocol/go (proto) version to latest release in pom.xml
  • remove builder reference/import in reserved proto request field

@jakedoublev jakedoublev requested review from a team as code owners October 9, 2025 19:53
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jakedoublev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a minor cleanup within the SDK by removing a specific proto field setting. The setWithValue call, which configured withKeyAccessGrants(true) for the GetAttributeValuesByFqnsRequest, was identified as reserved and unused. This change ensures that the request construction is more precise and efficient, aligning with best practices for proto message usage.

Highlights

  • Proto Field Removal: Removed the setWithValue call, which configured withKeyAccessGrants(true), from the GetAttributeValuesByFqnsRequest builder in Autoconfigure.java. This field was identified as reserved and unused, streamlining the request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the usage of a reserved and unused proto field with_value when building a GetAttributeValuesByFqnsRequest. The change is straightforward and correct, simplifying the code. I've added one minor suggestion to also remove the now-unused import for AttributeValueSelector.

pflynn-virtru
pflynn-virtru previously approved these changes Oct 9, 2025
pflynn-virtru
pflynn-virtru previously approved these changes Oct 9, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

@strantalis strantalis merged commit 50b0302 into main Oct 9, 2025
9 of 12 checks passed
@strantalis strantalis deleted the fix/DSPX-1614 branch October 9, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants