feat(sdk): add shorthand enum constants for policy types by marythought · Pull Request #357 · opentdf/java-sdk

marythought · 2026-04-28T16:14:46Z

Summary

Add PolicyEnums utility class with readable constant aliases for verbose protobuf enum names so developers can write PolicyEnums.OPERATOR_IN instead of SubjectMappingOperatorEnum.SUBJECT_MAPPING_OPERATOR_ENUM_IN
Update all examples to use the new shorthand constants via static imports
Companion to feat(sdk): add shorthand enum constants for policy types platform#3408 (Go SDK equivalent)

Constants added

Shorthand	Full proto name
`OPERATOR_IN`	`SUBJECT_MAPPING_OPERATOR_ENUM_IN`
`OPERATOR_NOT_IN`	`SUBJECT_MAPPING_OPERATOR_ENUM_NOT_IN`
`OPERATOR_IN_CONTAINS`	`SUBJECT_MAPPING_OPERATOR_ENUM_IN_CONTAINS`
`BOOLEAN_AND`	`CONDITION_BOOLEAN_TYPE_ENUM_AND`
`BOOLEAN_OR`	`CONDITION_BOOLEAN_TYPE_ENUM_OR`
`RULE_ALL_OF`	`ATTRIBUTE_RULE_TYPE_ENUM_ALL_OF`
`RULE_ANY_OF`	`ATTRIBUTE_RULE_TYPE_ENUM_ANY_OF`
`RULE_HIERARCHY`	`ATTRIBUTE_RULE_TYPE_ENUM_HIERARCHY`
`STATE_ACTIVE`	`ACTIVE_STATE_ENUM_ACTIVE`
`STATE_INACTIVE`	`ACTIVE_STATE_ENUM_INACTIVE`
`STATE_ANY`	`ACTIVE_STATE_ENUM_ANY`

Before / After

// Before
ConditionGroup.newBuilder()
    .setBooleanOperator(ConditionBooleanTypeEnum.CONDITION_BOOLEAN_TYPE_ENUM_AND)
    .addConditions(Condition.newBuilder()
        .setOperator(SubjectMappingOperatorEnum.SUBJECT_MAPPING_OPERATOR_ENUM_IN));

// After
import static io.opentdf.platform.sdk.PolicyEnums.*;

ConditionGroup.newBuilder()
    .setBooleanOperator(BOOLEAN_AND)
    .addConditions(Condition.newBuilder()
        .setOperator(OPERATOR_IN));

Test plan

mvn compile passes (full project including examples)
mvn test -Dtest=PolicyEnumsTest — 4 tests, all pass
CI passes

🤖 Generated with Claude Code

Summary by CodeRabbit

New Features
- Introduced simplified static constants for policy configuration, making attribute rules, operators, and boolean conditions more readable and intuitive to use.
Documentation
- Updated example code to demonstrate the new simplified policy constants.
Tests
- Added test coverage validating the new policy configuration constants.

Add PolicyEnums utility class with readable constant aliases for verbose protobuf enum names so developers can write PolicyEnums.OPERATOR_IN instead of SubjectMappingOperatorEnum.SUBJECT_MAPPING_OPERATOR_ENUM_IN. Constants added for SubjectMappingOperatorEnum, ConditionBooleanTypeEnum, AttributeRuleTypeEnum, and ActiveStateEnum. Examples updated to use the new shorthand via static imports. Companion to opentdf/platform#3408 (Go SDK equivalent). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Mary Dickson <mary.dickson@virtru.com>

coderabbitai · 2026-04-28T16:15:01Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0540e7ca-6df7-4c46-bf58-ad580b93b4f3

📥 Commits

Reviewing files that changed from the base of the PR and between 1d2fde6 and 4b5aa4e.

📒 Files selected for processing (5)

examples/src/main/java/io/opentdf/platform/CreateAttribute.java
examples/src/main/java/io/opentdf/platform/CreateSubjectConditionSet.java
examples/src/main/java/io/opentdf/platform/CreateSubjectMapping.java
sdk/src/main/java/io/opentdf/platform/sdk/PolicyEnums.java
sdk/src/test/java/io/opentdf/platform/sdk/PolicyEnumsTest.java

📝 Walkthrough

Walkthrough

This PR introduces a new PolicyEnums utility class that exposes readable static constant aliases for policy-related protobuf enums, then refactors example code to use these cleaner constants instead of direct enum references.

Changes

Cohort / File(s)	Summary
New PolicyEnums Utility `sdk/src/main/java/io/opentdf/platform/sdk/PolicyEnums.java`, `sdk/src/test/java/io/opentdf/platform/sdk/PolicyEnumsTest.java`	Introduces final utility class with 11 static constant aliases for operator, boolean, rule, and active-state enum types. Includes comprehensive JUnit 5 tests validating all constant mappings.
Example Code Refactoring `examples/src/main/java/io/opentdf/platform/CreateAttribute.java`, `examples/src/main/java/io/opentdf/platform/CreateSubjectConditionSet.java`, `examples/src/main/java/io/opentdf/platform/CreateSubjectMapping.java`	Updated to use static constants from `PolicyEnums` instead of referencing protobuf enum types directly; imports simplified with wildcard static imports.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

mkleene

Poem

🐰 Constants hop into view, so clean and bright,
No more enum paths, just names that feel right!
From OPERATOR_IN to RULE_ALL_OF, hooray—
PolicyEnums makes the code dance today! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'feat(sdk): add shorthand enum constants for policy types' clearly and specifically describes the main change: introducing shorthand enum constants for policy types in the SDK.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/enum-helpers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request introduces a new utility class, PolicyEnums, which provides shorthand constants for commonly used policy enum values to improve code readability. The existing example classes have been updated to utilize these constants via static imports, and a corresponding test suite has been added to verify the enum mappings. I have no feedback to provide as the changes are clean and well-structured.

sonarqubecloud · 2026-04-28T16:17:32Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-04-28T16:45:24Z

X-Test Results

✅ java-main
✅ java-v0.14.0
✅ js-main
✅ js-v0.14.0
✅ go-v0.14.0
✅ go-main

… badges - Update JS imports to use barrel exports from @opentdf/sdk instead of deep proto paths - Update policy.mdx Java example to use PolicyEnums shorthand constants - Update policy.mdx JS example to use enum values instead of strings - Add SdkVersion badges with NEXT placeholders to code samples (replace with actual versions once SDK releases ship) Note: Java code_samples/java/ files are pulled from the java-sdk repo at build time via remote-content plugin. They will update automatically once javaSdkVersion is bumped in docusaurus.config.ts after the java-sdk release containing opentdf/java-sdk#357. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Mary Dickson <mary.dickson@virtru.com>

…928) Re-export SubjectMappingOperatorEnum, ConditionBooleanTypeEnum, AttributeRuleTypeEnum, and ActiveStateEnum from the main @opentdf/sdk entry point so users can import them directly instead of reaching into generated proto paths. Companion to opentdf/platform#3408 (Go SDK) and opentdf/java-sdk#357 (Java SDK). Signed-off-by: Mary Dickson <mary.dickson@virtru.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

dmihalcik-virtru

We need to wire up a formatter with import sorting for examples, it seems

🤖 I have created a release *beep* *boop* --- <details><summary>0.15.0</summary> ## [0.15.0](v0.14.0...v0.15.0) (2026-04-29) ### Features * **sdk:** add shorthand enum constants for policy types ([#357](#357)) ([a1d4651](a1d4651)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>

… badges - Update JS imports to use barrel exports from @opentdf/sdk instead of deep proto paths - Update policy.mdx Java example to use PolicyEnums shorthand constants - Update policy.mdx JS example to use enum values instead of strings - Add SdkVersion badges with NEXT placeholders to code samples (replace with actual versions once SDK releases ship) Note: Java code_samples/java/ files are pulled from the java-sdk repo at build time via remote-content plugin. They will update automatically once javaSdkVersion is bumped in docusaurus.config.ts after the java-sdk release containing opentdf/java-sdk#357. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Mary Dickson <mary.dickson@virtru.com>

marythought requested review from a team as code owners April 28, 2026 16:14

gemini-code-assist Bot reviewed Apr 28, 2026

View reviewed changes

marythought mentioned this pull request Apr 28, 2026

feat(sdk): re-export policy enums from barrel for convenient imports opentdf/web-sdk#928

Merged

5 tasks

marythought mentioned this pull request Apr 28, 2026

chore(docs): use shorthand enum names in subject mapping docs opentdf/docs#308

Open

3 tasks

dmihalcik-virtru approved these changes Apr 29, 2026

View reviewed changes

marythought merged commit a1d4651 into main Apr 29, 2026
19 checks passed

marythought deleted the feat/enum-helpers branch April 29, 2026 14:44

opentdf-automation Bot mentioned this pull request Apr 29, 2026

chore(main): release 0.15.0 #358

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(sdk): add shorthand enum constants for policy types#357

feat(sdk): add shorthand enum constants for policy types#357
marythought merged 1 commit intomainfrom
feat/enum-helpers

marythought commented Apr 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 28, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

sonarqubecloud Bot commented Apr 28, 2026

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

dmihalcik-virtru left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

marythought commented Apr 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Constants added

Before / After

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

sonarqubecloud Bot commented Apr 28, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Apr 28, 2026

X-Test Results

Uh oh!

dmihalcik-virtru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

marythought commented Apr 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 28, 2026 •

edited

Loading