Skip to content

chore(core): Bump go patch to 1.24.12#3037

Merged
dmihalcik-virtru merged 1 commit intomainfrom
fix-govulncheck
Jan 30, 2026
Merged

chore(core): Bump go patch to 1.24.12#3037
dmihalcik-virtru merged 1 commit intomainfrom
fix-govulncheck

Conversation

@dmihalcik-virtru
Copy link
Copy Markdown
Member

Proposed Changes

  • Fixes govulncheck

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@dmihalcik-virtru dmihalcik-virtru requested review from a team as code owners January 29, 2026 17:40
@github-actions github-actions Bot added comp:ci Github Actions Work comp:sdk A software development kit, including library, for client applications and inter-service communicati comp:examples comp:lib:fixtures comp:lib:ocrypto size/s labels Jan 29, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a routine maintenance update by bumping the Go toolchain version across various modules within the project and the main Go workspace. The primary goal of this change is to address and mitigate potential vulnerabilities or issues flagged by govulncheck, ensuring the project leverages the latest stability and security improvements from the updated Go patch release.

Highlights

  • Go Toolchain Update: The Go toolchain version has been updated from go1.24.11 to go1.24.12 across all affected modules and the Go workspace configuration.
  • Addresses govulncheck Issues: This patch update is specifically intended to resolve and fix issues identified by the govulncheck tool, enhancing security and stability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/checks.yaml
    • .github/workflows/vulnerability-check.yaml
  • Ignored by pattern: protocol/**/* (1)
    • protocol/go/go.mod
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


New patch arrives swift, Old vulnerabilities flee, Code now stands secure.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully updates the Go toolchain and module versions across various go.mod and go.work files from 1.24.11 to 1.24.12. This change aligns with the stated goal of fixing govulncheck issues, which is a positive step for maintaining the project's security and stability. The changes are straightforward and correctly applied across all relevant modules.

@github-actions
Copy link
Copy Markdown
Contributor

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 153.626694ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 87.981747ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 377.468895ms
Throughput 264.92 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 39.778330026s
Average Latency 396.264986ms
Throughput 125.70 requests/second

@github-actions
Copy link
Copy Markdown
Contributor

@dmihalcik-virtru dmihalcik-virtru added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit 5534e92 Jan 30, 2026
95 of 99 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the fix-govulncheck branch January 30, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:ci Github Actions Work comp:examples comp:lib:fixtures comp:lib:ocrypto comp:sdk A software development kit, including library, for client applications and inter-service communicati size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants