feat(core): IPC metadata forwarding#3099
Conversation
Summary of ChangesHello @alkalescent, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Inter-Process Communication (IPC) mechanism by enabling the transparent forwarding of generic gRPC metadata between services. It achieves this by serializing incoming gRPC context metadata into Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Headers flow unseen, Metadata, context deep, Services now speak. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to forward gRPC metadata across Inter-Process Communication (IPC) calls by encoding them as HTTP headers. However, the IPCUnaryServerInterceptor implementation is insecure, as it blindly promotes any HTTP header with the x-ipc-meta- prefix to the request's gRPC metadata context. This poses a significant risk of metadata spoofing, potentially bypassing security controls like tenant isolation. A strict allow-list for forwarded metadata keys is crucial to mitigate this. Additionally, the review suggests improving code clarity, simplifying the server interceptor, and implementing an explicit allow-list for the client interceptor to prevent potential side effects.
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
| continue | ||
| } | ||
| for _, v := range vals { | ||
| req.Header().Add(ipcMetadataHeaderPrefix+key, v) |
There was a problem hiding this comment.
should we wrap ipcMetadataHeaderPrefix+key with http.CanonicalHeaderKey()? the restore logic below looks like it expects that format
3 participants
Proposed Changes
Checklist
Testing Instructions