Skip to content

fix(ci): prevent code injection in release-otdfctl workflow#3308

Merged
alkalescent merged 1 commit intoDSPX-2655-migrate-otdfctlfrom
otdfctl-zizmor-issues
Apr 15, 2026
Merged

fix(ci): prevent code injection in release-otdfctl workflow#3308
alkalescent merged 1 commit intoDSPX-2655-migrate-otdfctlfrom
otdfctl-zizmor-issues

Conversation

@alkalescent
Copy link
Copy Markdown
Contributor

Proposed Changes

  • Fix two zizmor-flagged code injection vulnerabilities in release-otdfctl.yaml by passing github.event.release.tag_name through env: variables instead of direct template expansion in run: blocks.

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

No functional change — the workflow behaves identically, but tag name values are now injected as environment variables rather than interpolated into shell scripts.

@alkalescent alkalescent requested review from a team as code owners April 15, 2026 17:28
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 15, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f71dbd57-4703-47c1-a994-21c53a3d5bbb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch otdfctl-zizmor-issues

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added comp:ci Github Actions Work size/xs labels Apr 15, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 194.957821ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 107.556365ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 411.608988ms
Throughput 242.95 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 41.081064765s
Average Latency 409.165047ms
Throughput 121.71 requests/second

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

  • examples
  • otdfctl
  • sdk
  • service
  • lib/fixtures
  • tests-bdd

See the workflow run for details.

@alkalescent alkalescent merged commit 9bba58a into DSPX-2655-migrate-otdfctl Apr 15, 2026
37 of 38 checks passed
@alkalescent alkalescent deleted the otdfctl-zizmor-issues branch April 15, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:ci Github Actions Work size/xs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants