Skip to content

chore(deps): bump connectrpc/connect to v1.20.0 in sdk, service, otdfctl#3589

Merged
jakedoublev merged 1 commit into
mainfrom
chore/bump-connect-v1.20
Jun 9, 2026
Merged

chore(deps): bump connectrpc/connect to v1.20.0 in sdk, service, otdfctl#3589
jakedoublev merged 1 commit into
mainfrom
chore/bump-connect-v1.20

Conversation

@marythought

@marythought marythought commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Bumps connectrpc.com/connect from v1.19.2 to v1.20.0 in sdk/, service/, and otdfctl/
  • protocol/go is already on v1.20.0 — this aligns the rest of the repo
  • Resolves internal version skew that was blocking downstream consumers (virtru-sdk-go, DSP SDK) from upgrading

Context

Identified in the Dependency Version Audit — connect v1.19.2 vs v1.20.0 split within platform was preventing downstream repos from bumping without breaking compatibility.

Test plan

  • CI passes (go-checks, tests, lint)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated core library dependency versions across modules to improve stability and ensure compatibility.

Aligns these modules with protocol/go which is already on v1.20.0.
Resolves internal version skew that was blocking downstream consumers
(virtru-sdk-go, DSP SDK) from upgrading.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mary Dickson <mary.dickson@virtru.com>
@marythought marythought requested review from a team as code owners June 8, 2026 22:30
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a dependency maintenance task to align the connectrpc/connect library version across multiple modules in the repository. By standardizing on v1.20.0, the change eliminates internal version mismatches that were previously blocking downstream SDK consumers from upgrading their own dependencies.

Highlights

  • Dependency Update: Updated the connectrpc/connect dependency from v1.19.2 to v1.20.0 across the sdk, service, and otdfctl modules.
  • Version Alignment: Aligned the platform's dependency versions with protocol/go to resolve version skew and prevent compatibility issues for downstream consumers.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.


The versions were split in the code, A burden that heavy did load. We bumped up the trace, To a unified space, And now we are back on the road.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions Bot added the comp:sdk A software development kit, including library, for client applications and inter-service communicati label Jun 8, 2026
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: c7b50963-9d3d-444e-b438-e83e01b059a7

📥 Commits

Reviewing files that changed from the base of the PR and between 8f3c429 and 36a9091.

⛔ Files ignored due to path filters (3)
  • otdfctl/go.sum is excluded by !**/*.sum
  • sdk/go.sum is excluded by !**/*.sum
  • service/go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • otdfctl/go.mod
  • sdk/go.mod
  • service/go.mod

📝 Walkthrough

Walkthrough

This PR updates the connectrpc.com/connect dependency from v1.19.2 to v1.20.0 across three Go modules: otdfctl, sdk, and service. All changes are straightforward dependency version bumps with no code modifications.

Changes

Connect RPC Dependency Upgrade

Layer / File(s) Summary
Bump connectrpc.com/connect to v1.20.0 across modules
service/go.mod, sdk/go.mod, otdfctl/go.mod
The connectrpc.com/connect dependency is uniformly upgraded from v1.19.2 to v1.20.0 across all three Go module files in the repository.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested labels

comp:sdk, size/xs

Suggested reviewers

  • elizabethhealy
  • pflynn-virtru
  • c-r33d

Poem

🐰 Three modules dance in perfect sync,
Connecting rabbits to the brink—
v1.20.0 brings the cheer,
Dependencies updated, crystal clear! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title clearly and concisely describes the main change: bumping connectrpc/connect dependency to v1.20.0 across three modules (sdk, service, otdfctl).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-connect-v1.20

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/s label Jun 8, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the connectrpc.com/connect dependency from version 1.19.2 to 1.20.0 in the otdfctl, sdk, and service modules. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 190.693931ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric Value
Approved Decision Requests 1000
Denied Decision Requests 0
Total Time 95.258891ms

Benchmark Statistics

Name № Requests Avg Duration Min Duration Max Duration

Bulk Benchmark Results

Metric Value
Total Decrypts 100
Successful Decrypts 100
Failed Decrypts 0
Total Time 600.906698ms
Throughput 166.42 requests/second

TDF3 Benchmark Results:

Metric Value
Total Requests 5000
Successful Requests 5000
Failed Requests 0
Concurrent Requests 50
Total Time 43.120344472s
Average Latency 428.752304ms
Throughput 115.95 requests/second

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ Govulncheck found vulnerabilities ⚠️

The following modules have known vulnerabilities:

  • examples
  • otdfctl
  • sdk
  • service
  • lib/fixtures
  • tests-bdd

See the workflow run for details.

@marythought marythought marked this pull request as draft June 8, 2026 22:53
@marythought

Copy link
Copy Markdown
Contributor Author

connect v1.20.0 changes (release notes):

  1. Minimum Go bumped to 1.25 — all platform modules are already on Go 1.25.0+
  2. Query parameter ordering fix — spec compliance, low risk

No breaking API changes. All downstream repos (DSP at Go 1.25.9, virtru-sdk-go at 1.25.11) are also on Go 1.25+, so the floor bump is a non-issue.

@marythought marythought marked this pull request as ready for review June 8, 2026 22:55
@jakedoublev jakedoublev added this pull request to the merge queue Jun 9, 2026
Merged via the queue into main with commit 8d446b3 Jun 9, 2026
43 checks passed
@jakedoublev jakedoublev deleted the chore/bump-connect-v1.20 branch June 9, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:sdk A software development kit, including library, for client applications and inter-service communicati size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants