Skip to content

chore(xtest): Enable key_management tests#415

Merged
dmihalcik-virtru merged 5 commits intoopentdf:mainfrom
dmihalcik-virtru:chore/xtest-key-management-enablement
Feb 17, 2026
Merged

chore(xtest): Enable key_management tests#415
dmihalcik-virtru merged 5 commits intoopentdf:mainfrom
dmihalcik-virtru:chore/xtest-key-management-enablement

Conversation

@dmihalcik-virtru
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru commented Feb 13, 2026

and ec-wrapped on java and web sdks. Unfortunately, there is a bug in the java version (unable to build KAO arrays with mixed mechanism types)

test_abac for focus=js previously:

================= 134 passed, 124 skipped in 377.87s (0:06:17) =================

Now:

================= 169 passed, 89 skipped in 513.18s (0:08:33) ==================

@dmihalcik-virtru dmihalcik-virtru requested review from a team as code owners February 13, 2026 16:19
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on expanding the test suite capabilities for both Java and JavaScript SDKs. It introduces checks to enable advanced key management tests for newer SDK versions and refines an existing version check for the ecwrap feature in the JavaScript SDK, ensuring more accurate compatibility detection for testing.

Highlights

  • Java SDK Key Management Test Enablement: Enabled testing for advanced key management features in the Java SDK by adding a version check to ensure the SDK is at least version 0.10.0.
  • JavaScript SDK Key Management Test Enablement: Enabled testing for advanced key management features in the JavaScript SDK by adding a version check to ensure the SDK is at least version 0.8.0.
  • JavaScript SDK ECWrap Version Check Refinement: Updated the version check logic for the ecwrap feature in the JavaScript SDK to correctly identify support from SDK version 0.5.0 onwards, rather than only versions greater than 2.x.x.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • xtest/sdk/java/cli.sh
    • Added a new 'key_management' support check that verifies the Java SDK version is 0.10.0 or greater.
  • xtest/sdk/js/cli.sh
    • Updated the 'ecwrap' support check to correctly identify SDK versions 0.5.0 and above.
    • Added a new 'key_management' support check that verifies the JavaScript SDK version is 0.8.0 or greater.
Activity
  • No specific activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables key_management tests for the Java and JS SDKs by adding version checks, and also updates the ecwrap version check for the JS SDK. The logic for version checking is correct. My feedback focuses on improving the robustness of these checks by incorporating set -o pipefail, which is a pattern already present in the files for other checks. This will ensure more reliable error handling within the command pipelines.

@dmihalcik-virtru dmihalcik-virtru force-pushed the chore/xtest-key-management-enablement branch from 0197e69 to 0fcfb41 Compare February 16, 2026 15:49
@dmihalcik-virtru dmihalcik-virtru merged commit c0b9ea4 into opentdf:main Feb 17, 2026
5 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the chore/xtest-key-management-enablement branch February 17, 2026 17:37
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants