chore(xtest): Enable key_management tests#415
Conversation
Summary of ChangesHello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on expanding the test suite capabilities for both Java and JavaScript SDKs. It introduces checks to enable advanced key management tests for newer SDK versions and refines an existing version check for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enables key_management tests for the Java and JS SDKs by adding version checks, and also updates the ecwrap version check for the JS SDK. The logic for version checking is correct. My feedback focuses on improving the robustness of these checks by incorporating set -o pipefail, which is a pattern already present in the files for other checks. This will ensure more reliable error handling within the command pipelines.
and ec-wrapped on java and web sdks
0197e69 to
0fcfb41
Compare
|



and ec-wrapped on java and web sdks. Unfortunately, there is a bug in the java version (unable to build KAO arrays with mixed mechanism types)
test_abac for focus=js previously:
Now: