fix(xtest): Enable extended rsa tests for java >= v0.13.0#417
fix(xtest): Enable extended rsa tests for java >= v0.13.0#417elizabethhealy merged 7 commits intomainfrom
Conversation
X-Test Failure Report |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
…om/opentdf/tests into dspx-2517-enable-rsa-extended-java
X-Test Failure Report |
X-Test Failure Report |
elizabethhealy
changed the title
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables extended RSA tests for the Java SDK for versions 0.13.0 and newer. The changes involve updating a shell script to detect SDK version capabilities and modifying a Python test file to use this detection logic. My review includes a correction to the version checking logic to align with the intended support range and a suggestion to improve code clarity by removing commented-out code.
I am having trouble creating individual review comments. Click here to see my feedback.
xtest/sdk/java/cli.sh (95-97)
The version check logic appears to implement support for versions > 0.12.0, but the pull request title indicates support starts from v0.13.0. The current logic would incorrectly succeed for versions like 0.12.1, which is not >= 0.13.0. The logic should be simplified to check for versions >= 0.13.0 to match the intended change. I've also updated the comment to reflect this.
# rsa4096 support in >= 0.13.0
set -o pipefail
java -jar "$SCRIPT_DIR"/cmdline.jar --version | jq -re .version | awk -F. '{ if ($1 > 0 || ($1 == 0 && $2 >= 13)) exit 0; else exit 1; }'
xtest/tdfs.py (456-457)
To improve readability and avoid leaving dead code in the codebase, it's better to remove these commented-out lines entirely. The logic will then correctly fall through to the default supports check, which calls the cli.sh script.
X-Test Results✅ js-v0.13.0 |
elizabethhealy
changed the title
2 participants
Java sdk enables rsa 4096 with opentdf/java-sdk#343, passing the tests against this branch
Dynamic version check for RSA 4096 support: A new mechanism was introduced in cli.sh to dynamically check if the Java SDK version supports RSA 4096, specifically for versions at or above 0.13.0.