Skip to content

Change update_moving_price() function #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sam0x17 merged 3 commits into from
Apr 4, 2025
Merged

Change update_moving_price() function #1510

sam0x17 merged 3 commits into from
Apr 4, 2025
+19 −14

Conversation

@sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Apr 4, 2025 •
edited
Loading

change the function to use FirstEmissionBlockNumber parameter instead of NetworkRegisteredAt.

hotfix version of #1496

@shamil-gadelshin @sam0x17
Change update_moving_price() function
64af769 
- change the function to use FirstEmissionBlockNumber parameter instead of NetworkRegisteredAt.
@sam0x17 sam0x17 self-assigned this Apr 4, 2025
@github-actions github-actions bot added the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Apr 4, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

🚨🚨🚨 HOTFIX DETECTED 🚨🚨🚨

It looks like you are trying to merge a hotfix PR into main. If this isn't what you wanted to do, and you just wanted to make a regular PR, please close this PR, base your changes off the devnet-ready branch and open a new PR into devnet ready.

If you are trying to merge a hotfix PR, please complete the following essential steps:

  1. go ahead and get this PR into main merged, so we can get the change in as quickly as possible!
  2. merge main into testnet, bumping spec_version
  3. deploy testnet
  4. merge testnet into devnet, bumping spec_version
  5. deploy devnet
  6. merge devnet into devnet-ready

If you do not complete these steps, your hotfix may be inadvertently removed in the future when branches are promoted to main, so it is essential that you do so.

@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Apr 4, 2025
@sam0x17 sam0x17 merged commit 719a6f5 into main Apr 4, 2025
49 checks passed
@shibshib shibshib self-requested a review April 6, 2025 06:20
This was referenced Apr 10, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camfairchild camfairchild camfairchild approved these changes

@ales-otf ales-otf ales-otf approved these changes

@gztensor gztensor Awaiting requested review from gztensor

@shibshib shibshib Awaiting requested review from shibshib

Assignees

@sam0x17 sam0x17

Labels

hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sam0x17 @camfairchild @ales-otf @shamil-gadelshin