Type safe swap interface #2011
Merged
Type safe swap interface #2011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ales-otf
force-pushed
the
feat/type-safe-swap
branch
from
a4b5459 to
b3be47d
Compare
ales-otf
force-pushed
the
feat/type-safe-swap
branch
from
b47da7b to
dae1677
Compare
ales-otf
requested review from
JohnReedV,
camfairchild,
gztensor,
l0r1s,
open-junius,
shamil-gadelshin and
unconst
sam0x17
added
apply-benchmark-patch
skip-cargo-audit
sam0x17
previously approved these changes
Oct 3, 2025
l0r1s
reviewed
Oct 3, 2025
pallets/subtensor/src/tests/mock.rs
Outdated
|
|
||
| let result = result.unwrap(); | ||
|
|
||
| // we don't want to have silent 0 comparissons in tests |
There was a problem hiding this comment.
Suggested change
| // we don't want to have silent 0 comparissons in tests | |
| // we don't want to have silent 0 comparisons in tests |
l0r1s
reviewed
Oct 3, 2025
Comment on lines
4166
to
4171
| // let fee = <Test as Config>::SwapInterface::approx_fee_amount(netuid.into(), (amount as f64 * 0.99) as u64); | ||
| // let fee = <Test as Config>::SwapExt::approx_fee_amount(netuid.into(), (amount as f64 * 0.99) as u64); |
There was a problem hiding this comment.
Isn't this suppose to be SwapInterface and not SwapExt ?
l0r1s
reviewed
Oct 3, 2025
| let stake_amount = TaoCurrency::from(100_000_000_000); | ||
|
|
||
| let default_fee = 0; // FIXME: DefaultStakingFee is deprecated | ||
| let default_fee = TaoCurrency::ZERO; // FIXME: DefaultStakingFee is deprecated |
There was a problem hiding this comment.
Is this comment still valid?
Suggested change
| let default_fee = TaoCurrency::ZERO; // FIXME: DefaultStakingFee is deprecated | |
| let default_fee = TaoCurrency::ZERO; |
There was a problem hiding this comment.
The test still relies on this value. We should probably refactor the test.
l0r1s
previously approved these changes
Oct 6, 2025
gztensor
requested changes
Oct 6, 2025
| let order = GetAlphaForTao::<T>::with_amount(u64::MAX); | ||
| let result = T::SwapInterface::swap(netuid.into(), order, limit_price, false, true) | ||
| .map(|r| r.amount_paid_in.saturating_add(r.fee_paid)) | ||
| .map_err(|_| Error::ZeroMaxStakeAmount)?; |
There was a problem hiding this comment.
Someone in the community was complaining about this error. We actually have PriceLimitExceeded, which is much more readable for the end user. I think we can replace it for PriceLimitExceeded because get_max_amount_add is only used for adding or moving stake.
| let order = GetTaoForAlpha::<T>::with_amount(u64::MAX); | ||
| let result = T::SwapInterface::swap(netuid.into(), order, limit_price.into(), false, true) | ||
| .map(|r| r.amount_paid_in.saturating_add(r.fee_paid)) | ||
| .map_err(|_| Error::ZeroMaxStakeAmount)?; |
There was a problem hiding this comment.
Same comment here: Consider replacing with PriceLimitExceeded.
There was a problem hiding this comment.
Sure, I'll do these changes!
gztensor
approved these changes
Oct 7, 2025
sam0x17
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a refactoring of swap interface and swap pallet to make it have a static dispatch and to be type safe.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.