Automatically set 0 to deregistered subnets

[shibshib]

This will ensure that when subnets are deregistered, its weights are automagically set to 0.

[sam0x17]

Looks good in general, one loop I think could be improved significantly

[shibshib]

Thanks @sam0x17 this was super helpful, updated the loop after testing.

[sam0x17]

@shibshib did you have any thoughts regarding what I was saying about "is there anything we can do to avoid looping over the whole vec" -- I don't have enough context to know the topology of the weights_i vec but I'm curious what the details are here, like can an id be repeated, is the order random, etc

[shibshib]

@shibshib did you have any thoughts regarding what I was saying about "is there anything we can do to avoid looping over the whole vec" -- I don't have enough context to know the topology of the weights_i vec but I'm curious what the details are here, like can an id be repeated, is the order random, etc

We unfortunately have to loop through the whole vec. The vector itself contains the weights set by validators for all subnets. If a subnet's weight must be reset to 0, it has to be reset by every validator as well. Hence, it's hard to optimize that further, I don't think. Open to suggestions though!

[sam0x17]

should be good as-is then 👍🏻

[unconst]

LGTM