Skip to content

upgrade to polkadot 1.0 #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 177 commits into from
Apr 8, 2024
Merged

upgrade to polkadot 1.0 #252

merged 177 commits into from
Apr 8, 2024

Conversation

@sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Mar 11, 2024 •
edited by keithtensor
Loading

  • breaking changes for 0.9.39 => 1.0 (tons of stuff, but one bullet point now lol)
  • revamp CI, now broken into 6 separate jobs, takes no more than ~6-7 mins to complete, cargo fmt feedback in ~22 seconds, cargo check --workspace in about 3 mins 😎, also added CI checks for clippy and one that asserts that cargo fix has no trivial fixes available
  • cargo check passing
  • cargo check --workspace passing
  • cargo test compiling
  • cargo test --workspace compiling
  • cargo test --workspace passing
  • cargo test --workspace --features=runtime-benchmarks compiling
  • cargo test --workspace --features=runtime-benchmarks passing

fixes #275

sam0x17 added 23 commits March 11, 2024 12:54
@sam0x17
set version to 1.0 and rename sc-finality-grandpa => sc-consensus-gra…
650747a 
…ndpa
@sam0x17
fix some versions
049ee2c
@sam0x17
sp-finality-grandpa => sp-consensus-grandpa
ca94936
@sam0x17
more versions fixed
053229e
@sam0x17
update crates
d1071b6
@sam0x17
set rust version to 1.78 nightly
caf7fad
@sam0x17
fix GenesisBuild re-export issue
8b3e946
@sam0x17
use 2.0 resolver
266dc6e
@sam0x17
BlockNumber => BlockNumberFor<T>
47c9800
@sam0x17
Weight::from_ref_time(N) => Weight::from_parts(N, 0)
7d3c04e
@sam0x17
Weight::from_proof_size(N) => Weight::from_parts(0, N)
440ffae
@sam0x17
workaround for From<OldWeight> impl removed
b81233a
@sam0x17
frame_support::inherent::Vec => sp_std::vec::Vec
ee0cf6b
@sam0x17
cargo fmt
505c607
@sam0x17
remove trailing whitespace, cargo fmt passing 🎉
bcaf453
@sam0x17
GenesisBuild => BuildGenesisConfig
f68940c
@sam0x17
add two things the regex missed
306e1f0
@sam0x17
fix more genesis configs
9aa1d10
@sam0x17
migrate more block numbers
323ac1c
@sam0x17
remove Index
7e52e55
@sam0x17
remove Header and BlockNumber since they are now included by default
90891a0
@sam0x17
set AllowMultipleBlocksPerSlot = Get<false>;
62b8cb6
@sam0x17
add missing metadata methods
7ef5d89
@sam0x17 sam0x17 changed the title Sam upgrade to polkadot 1.0 upgrade to polkadot 1.0 Mar 11, 2024
@keithtensor keithtensor marked this pull request as ready for review April 4, 2024 17:06
@sam0x17 sam0x17 requested a review from shibshib April 5, 2024 18:10
@shibshib
Copy link
Contributor

shibshib commented Apr 5, 2024

Don't forget to update spec version to 145

sam0x17
sam0x17 commented Apr 5, 2024
View reviewed changes
sam0x17
sam0x17 commented Apr 5, 2024
View reviewed changes
sam0x17
sam0x17 commented Apr 5, 2024
View reviewed changes
Copy link
Contributor Author

@sam0x17 sam0x17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giving this my blessing as I can't actually approve

@sam0x17 sam0x17 mentioned this pull request Apr 5, 2024
Open
@sam0x17 sam0x17 added the enhancement New feature or request label Apr 5, 2024
open-junius
open-junius approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@open-junius open-junius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

distributedstatemachine
distributedstatemachine approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@distributedstatemachine distributedstatemachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sam0x17 sam0x17 merged commit 18f2c94 into development Apr 8, 2024
@sam0x17 sam0x17 deleted the sam-upgrade-polkadot-1.0 branch April 8, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@distributedstatemachine distributedstatemachine distributedstatemachine approved these changes

@open-junius open-junius open-junius approved these changes

@shibshib shibshib Awaiting requested review from shibshib

@unconst unconst Awaiting requested review from unconst

@JohnReedV JohnReedV Awaiting requested review from JohnReedV

+1 more reviewer

@keithtensor keithtensor keithtensor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sam0x17 sam0x17

@keithtensor keithtensor

@open-junius open-junius

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to Polkadot 1.0

6 participants

@sam0x17 @shibshib @distributedstatemachine @keithtensor @open-junius