Skip to content

CK cooldown after start call#2548

Merged
sam0x17 merged 1 commit intodevnet-readyfrom
feat/ck-cooldown-after-start-call
Mar 31, 2026
Merged

CK cooldown after start call#2548
sam0x17 merged 1 commit intodevnet-readyfrom
feat/ck-cooldown-after-start-call

Conversation

@gztensor
Copy link
Copy Markdown
Contributor

Description

When adding child keys, child key cool down period will begin only after start call is executed.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Mar 30, 2026
Comment on lines +610 to +612
} else {
current_block.saturating_add(cooldown_period)
};
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the impression that what was discussed is to have no delay before the start call, have it done instantly?

Copy link
Copy Markdown
Collaborator

@l0r1s l0r1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment about the requirement and also it could be nice to have some tests

@sam0x17 sam0x17 merged commit 5c8474f into devnet-ready Mar 31, 2026
197 of 210 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants