Merged
Conversation
JohnReedV
approved these changes
Mar 31, 2026
l0r1s
reviewed
Mar 31, 2026
Comment on lines
+610
to
+612
| } else { | ||
| current_block.saturating_add(cooldown_period) | ||
| }; |
Collaborator
There was a problem hiding this comment.
I get the impression that what was discussed is to have no delay before the start call, have it done instantly?
l0r1s
reviewed
Mar 31, 2026
Collaborator
l0r1s
left a comment
There was a problem hiding this comment.
Small comment about the requirement and also it could be nice to have some tests
sam0x17
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When adding child keys, child key cool down period will begin only after start call is executed.
Type of Change
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctly