Skip to content

Port more precompile tests to rust#2623

Merged
ales-otf merged 3 commits intodevnet-readyfrom
feat/precompile-rust-tests
Apr 29, 2026
Merged

Port more precompile tests to rust#2623
ales-otf merged 3 commits intodevnet-readyfrom
feat/precompile-rust-tests

Conversation

@ales-otf
Copy link
Copy Markdown
Contributor

Description

This is the last part with unit tests. The rest is going to be integration and what's left as E2E. This time it's crowdloan and leasing precompiles.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@ales-otf ales-otf added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Apr 28, 2026
@ales-otf ales-otf marked this pull request as ready for review April 29, 2026 10:45
Copy link
Copy Markdown
Collaborator

@l0r1s l0r1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Copy Markdown
Contributor

@open-junius open-junius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ales-otf ales-otf merged commit 2a8625a into devnet-ready Apr 29, 2026
207 of 208 checks passed
LandynDev added a commit to LandynDev/subtensor that referenced this pull request Apr 30, 2026
Resolves conflicts from upstream chore/imbalances merge (opentensor#2524) and
small follow-on PRs (opentensor#2621, opentensor#2623).

- chain-extensions/src/types.rs: add upstream's CannotUseSystemAccount=20,
  shift our CannotBurnOrRecycleOnRootSubnet to 21 and SubtokenDisabled to 22
- chain-extensions/src/tests.rs: switch our recycle/burn test calls from
  pallet_subtensor::Pallet::<mock::Test>::add_balance_to_coldkey_account
  to the mock free function (pallet method removed in opentensor#2524)
- docs/wasm-contracts.md: align Output table with new discriminants 21/22
- pallets/admin-utils/src/weights.rs: accept upstream regenerated
  sudo_set_total_issuance weights
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants