Set unlock and maturity rates to 90 days half life#2698
Conversation
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE BASELINE scrutiny: author has write permission, substantial prior subtensor PR history, matching author/committer identity, and no Gittensor allowlist match found; branch feat/unlock-rate-90-days -> devnet-ready. Static review found only a runtime economic-parameter update and the required FindingsNo findings. ConclusionNo malicious code path, supply-chain change, origin bypass, panic source, or security vulnerability was found in the diff. Review was static only, per Skeptic rules. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 LIKELY Gittensor / established contributor: no allowlist hit, but author has write permission and substantial prior subtensor PR activity; overlapping PRs do not appear to be same-purpose duplicates. PR body was empty/trivial; the Auditor has auto-filled it. Please review. Static domain audit only; I did not run build or tests because the diff only changes two default constants plus the runtime FindingsNo findings. ConclusionThe PR is narrowly scoped, consistent with its description, and does not introduce new extrinsics, storage, migrations, weights, or unsafe arithmetic. I found no blocking domain issues. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Description
This PR updates the default stake lock unlock and conviction maturity time constants so their exponential half-life is approximately 90 days at 12-second block time.
What Changed
DefaultUnlockRateinpallets/subtensor/src/lib.rsfrom648_000to934_866.DefaultMaturityRateinpallets/subtensor/src/lib.rsfrom648_000to934_866.runtime/src/lib.rsspec_versionfrom 410 to 411 for the runtime behavior change.Behavioral Impact
Existing storage values are not migrated. This changes the default values used when
UnlockRateorMaturityRateare absent, making 50% lock unlock and 50% conviction maturity occur in roughly 90 days rather than roughly 60 days.Migration / Spec Version
No storage migration is required. A runtime
spec_versionbump is included.Testing
Author checklist indicates
./scripts/fix_rust.shand existing unit tests were run locally. No new tests were added because this PR only changes default constants.