Skip to content

Set unlock and maturity rates to 90 days half life#2698

Merged
sam0x17 merged 2 commits into
devnet-readyfrom
feat/unlock-rate-90-days
May 27, 2026
Merged

Set unlock and maturity rates to 90 days half life#2698
sam0x17 merged 2 commits into
devnet-readyfrom
feat/unlock-rate-90-days

Conversation

@gztensor
Copy link
Copy Markdown
Contributor

@gztensor gztensor commented May 27, 2026

Description

This PR updates the default stake lock unlock and conviction maturity time constants so their exponential half-life is approximately 90 days at 12-second block time.

What Changed

  • Updated DefaultUnlockRate in pallets/subtensor/src/lib.rs from 648_000 to 934_866.
  • Updated DefaultMaturityRate in pallets/subtensor/src/lib.rs from 648_000 to 934_866.
  • Bumped runtime/src/lib.rs spec_version from 410 to 411 for the runtime behavior change.

Behavioral Impact

Existing storage values are not migrated. This changes the default values used when UnlockRate or MaturityRate are absent, making 50% lock unlock and 50% conviction maturity occur in roughly 90 days rather than roughly 60 days.

Migration / Spec Version

No storage migration is required. A runtime spec_version bump is included.

Testing

Author checklist indicates ./scripts/fix_rust.sh and existing unit tests were run locally. No new tests were added because this PR only changes default constants.

@github-actions github-actions Bot added the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label May 27, 2026
@gztensor gztensor changed the base branch from main to devnet-ready May 27, 2026 17:10
@gztensor gztensor removed the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label May 27, 2026
@opentensor opentensor deleted a comment from github-actions Bot May 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 27, 2026

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: author has write permission, substantial prior subtensor PR history, matching author/committer identity, and no Gittensor allowlist match found; branch feat/unlock-rate-90-days -> devnet-ready.

Static review found only a runtime economic-parameter update and the required spec_version bump. No .github/ai-review/* or .github/copilot-instructions.md changes were present.

Findings

No findings.

Conclusion

No malicious code path, supply-chain change, origin bypass, panic source, or security vulnerability was found in the diff. Review was static only, per Skeptic rules.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

LIKELY Gittensor / established contributor: no allowlist hit, but author has write permission and substantial prior subtensor PR activity; overlapping PRs do not appear to be same-purpose duplicates.

PR body was empty/trivial; the Auditor has auto-filled it. Please review.

Static domain audit only; I did not run build or tests because the diff only changes two default constants plus the runtime spec_version. The new 934_866 value matches a ~90-day half-life at 12-second blocks (648_000 / ln(2)), and the PR includes the required spec_version bump from 410 to 411.

Findings

No findings.

Conclusion

The PR is narrowly scoped, consistent with its description, and does not introduce new extrinsics, storage, migrations, weights, or unsafe arithmetic. I found no blocking domain issues.

@github-actions
Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@sam0x17 sam0x17 merged commit a535b29 into devnet-ready May 27, 2026
209 of 212 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants