Skip to content

Fixed dev tests#2776

Merged
open-junius merged 1 commit into
devnet-readyfrom
ci/dev-e2e-lsof
Jun 22, 2026
Merged

Fixed dev tests#2776
open-junius merged 1 commit into
devnet-readyfrom
ci/dev-e2e-lsof

Conversation

@evgeny-s

@evgeny-s evgeny-s commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Description

#2748 broke dev tests, because it doesn't have lsof, but this is required by moonwall.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@evgeny-s evgeny-s added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jun 22, 2026
@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

Baseline scrutiny: author has write permission, a 2012 GitHub account, and many prior subtensor PRs; branch ci/dev-e2e-lsof targets the expected devnet-ready base.

Findings

No findings.

Conclusion

Static review found no malicious behavior or security vulnerability. The diff only installs the standard lsof package for the dev E2E matrix and enables Moonwall multithreading for the dev test environment; it does not touch runtime, pallets, dependencies, secrets, privileged workflow triggers, or AI-review/copilot instruction files.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor: UNKNOWN by allowlist; author has write permission and substantial prior subtensor history, so review was calibrated as established-contributor CI maintenance.

The Auditor proposed a replacement PR description, but the current body is non-trivial; not overwriting. Maintainers: ask the Auditor to regenerate if you want it.

No domain findings.

The PR only changes the TypeScript E2E CI path: it installs lsof for the dev Moonwall matrix and enables multithreading for the dev Moonwall environment. It does not touch runtime or pallet code, so no spec_version bump is required. I did not run builds or tests because the diff is CI/config-only and no finding needed runtime confirmation.

Duplicate-work check: overlapping open PRs touch the same workflow/config files but are broader or unrelated workflow/test-suite changes, not better candidates for this narrow lsof/dev-test fix.

Findings

No findings.

Conclusion

Approve. The change is narrowly scoped to restoring dev TypeScript E2E execution and does not introduce runtime, economic, migration, dependency, or permission-surface risk.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@evgeny-s evgeny-s added skip-cargo-audit This PR fails cargo audit but needs to be merged anyway and removed skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Jun 22, 2026

@open-junius open-junius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@open-junius open-junius merged commit 169403f into devnet-ready Jun 22, 2026
245 of 263 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants