[cli] move public C APIs to dedicated cli_api.cpp#13016
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the codebase organization by decoupling the public C API definitions from the main CLI implementation file. By moving these functions to a dedicated file, the project achieves better modularity and cleaner separation of concerns within the CLI module. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
f743532 to
8be43ee
Compare
There was a problem hiding this comment.
Code Review
This pull request refactors the CLI implementation by moving the public C APIs from cli.cpp into a new dedicated file, cli_api.cpp. Corresponding updates were made to the GN and CMake build files to include the new source file in the build process. I have no feedback to provide.
This commit moves the public C APIs for the CLI from `cli.cpp` to a new dedicated file `cli_api.cpp`.
8be43ee to
c0f3c79
Compare
Library files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13016 +/- ##
==========================================
+ Coverage 69.01% 72.66% +3.65%
==========================================
Files 695 699 +4
Lines 98523 94059 -4464
==========================================
+ Hits 67992 68347 +355
+ Misses 30531 25712 -4819
🚀 New features to boost your workflow:
|
This commit moves the public C APIs for the CLI from
cli.cppto a new dedicated filecli_api.cpp.