Bazel: Remote coverage collection during buildbuddy coverage workflows is failing

[ivucica]

Possibly bazelbuild/bazel#20577 but we are on 6.x, due to the need to move various Bazel rules into the bzlmod setup (a future change).

Testrunner stdout:

exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //:util_test
-----------------------------------------------------------------------------
Running main() from gmock_main.cc
[==========] Running 2 tests from 2 test suites.
[----------] Global test environment set-up.
[----------] 1 test from StrReplaceTest
[ RUN      ] StrReplaceTest.BasicAssertions
[       OK ] StrReplaceTest.BasicAssertions (0 ms)
[----------] 1 test from StrReplaceTest (0 ms total)

[----------] 1 test from EqualityTest
[ RUN      ] EqualityTest.BasicAssertions
[       OK ] EqualityTest.BasicAssertions (0 ms)
[----------] 1 test from EqualityTest (0 ms total)

[----------] Global test environment tear-down
[==========] 2 tests from 2 test suites ran. (0 ms total)
[  PASSED  ] 2 tests.
File 'util.cpp'
Lines executed:3.14% of 159
File '/usr/include/c++/9/bits/stl_vector.h'
Lines executed:86.67% of 60
File '/usr/include/c++/9/bits/stl_uninitialized.h'
Lines executed:100.00% of 12
File '/usr/include/c++/9/bits/stl_construct.h'
Lines executed:100.00% of 12
File '/usr/include/c++/9/bits/move.h'
Lines executed:100.00% of 2
File '/usr/include/c++/9/ext/new_allocator.h'
Lines executed:81.82% of 11
File '/usr/include/c++/9/bits/stl_algobase.h'
Lines executed:34.62% of 26
File '/usr/include/c++/9/bits/alloc_traits.h'
Lines executed:80.00% of 10
File '/usr/include/c++/9/bits/stl_iterator_base_funcs.h'
No executable lines
File '/usr/include/c++/9/bits/stl_iterator_base_types.h'
No executable lines
File '/usr/include/c++/9/ext/type_traits.h'
No executable lines
File '/usr/include/c++/9/bits/cpp_type_traits.h'
Lines executed:0.00% of 2
File '/usr/include/c++/9/bits/basic_string.tcc'
No executable lines
File '/usr/include/c++/9/bits/stl_iterator.h'
Lines executed:37.50% of 16
File '/usr/include/c++/9/bits/vector.tcc'
Lines executed:28.57% of 28
File '/usr/include/c++/9/bits/basic_string.h'
Lines executed:71.43% of 21
File '/usr/include/c++/9/bits/allocator.h'
Lines executed:100.00% of 2
File '/usr/include/c++/9/ext/alloc_traits.h'
Lines executed:0.00% of 2
File '/usr/include/c++/9/bits/char_traits.h'
Lines executed:0.00% of 16
File '/usr/include/c++/9/new'
Lines executed:66.67% of 3
File 'util_test.cpp'
No executable lines
File 'external/com_google_googletest/googletest/include/gtest/internal/gtest-internal.h'
Lines executed:88.24% of 17
File '/usr/include/c++/9/iostream'
No executable lines
File 'external/com_google_googletest/googletest/include/gtest/gtest-printers.h'
Lines executed:0.00% of 26
File '/usr/include/c++/9/tuple'
Lines executed:0.00% of 6
File '/usr/include/c++/9/bits/stl_iterator_base_funcs.h'
No executable lines
File '/usr/include/c++/9/bits/stl_iterator_base_types.h'
No executable lines
File '/usr/include/c++/9/ext/type_traits.h'
No executable lines
File '/usr/include/c++/9/bits/basic_string.tcc'
No executable lines
File 'external/com_google_googletest/googletest/include/gtest/gtest.h'
Lines executed:38.46% of 13
File '/usr/include/c++/9/ext/new_allocator.h'
Lines executed:0.00% of 3
File '/usr/include/c++/9/bits/basic_string.h'
Lines executed:100.00% of 3
File '/usr/include/c++/9/bits/alloc_traits.h'
Lines executed:0.00% of 2
File '/usr/include/c++/9/bits/unique_ptr.h'
Lines executed:0.00% of 5
File '/usr/include/c++/9/ext/alloc_traits.h'
Lines executed:0.00% of 2
File '/usr/include/c++/9/bits/move.h'
No executable lines
File '/usr/include/c++/9/bits/char_traits.h'
Lines executed:33.33% of 12
File 'external/com_google_googletest/googletest/include/gtest/gtest-assertion-result.h'
Lines executed:25.00% of 4
File 'external/com_google_googletest/googletest/include/gtest/gtest-message.h'
No executable lines
File 'external/com_google_googletest/googletest/include/gtest/internal/gtest-port.h'
Lines executed:0.00% of 1
/buildbuddy-execroot/bazel-out/k8-opt-exec-34F00540/bin/external/remote_coverage_tools/Main: Cannot locate runfiles directory. (Set $JAVA_RUNFILES to inhibit searching.)

It's unclear how the coverage is triggered as it's not really in buildbuddy.yml (even though it's appreciated and beneficial to trigger the coverage workflows).

We should do one of these options

• disable coverage in buildbuddy workflows specifically, somehow, since I am not sure how we requested it in the first place (although it's actually a good idea to have it);
• somehow get BuildBuddy workflows to pass additional flags, perhaps by adjusting .bazelrc + ensuring our --config is used (mbland/rules_scala@7a011b9 or remote_coverage_tools/Main cannot locate runfiles directory when building with --nobuild_runfile_links bazelbuild/bazel#20577)
• have our test create $JAVA_RUNFILES dir and place a dummy file in there, even though that dir isn't really expected to exist since we don't run Java code

The last is the easiest to do, likely, so maybe that can be the first fix.

It would be good to figure out what made the coverage tests trigger, too.

[ivucica]

I think this is just Buildbuddy being extra friendly: the trigger is bazel coverage run from GitHub Actions, but the result is submitted by the Buildbuddy GH app as a checkrun, which is neat.

So we need to pass the extra flags in the actions CI workflow. No problem with that.