Skip to content

Conversation

@kagol
Copy link
Member

@kagol kagol commented Jan 13, 2026

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

Release Notes

  • Chores
    • Simplified internal demo configurations by standardizing toolbar settings across documentation examples.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 13, 2026
@kagol kagol merged commit 6554b4a into dev Jan 13, 2026
1 check passed
@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

Three demo files undergo toolbar configuration refactoring: custom TOOLBAR_CONFIG constants are removed, with editors now relying on DEFAULT_TOOLBAR composition and explicit plugin appending instead of predefined configurations.

Changes

Cohort / File(s) Summary
Toolbar Configuration Refactoring
packages/docs/fluent-editor/demos/i18n.vue
Removed TOOLBAR_CONFIG constant (22 lines). Editor now uses FULL_TOOLBAR and default behavior instead of custom multi-group toolbar with header levels, fonts, colors, alignment, lists, scripts, and table-up options.
Toolbar Configuration Refactoring
packages/docs/fluent-editor/demos/mind-map-resize.vue
Removed TOOLBAR_CONFIG constant (8 lines). Editor continues using DEFAULT_TOOLBAR with mind-map plugin appended.
Toolbar Configuration Refactoring
packages/docs/fluent-editor/demos/table-up-resize.vue
Replaced TOOLBAR_CONFIG with inline composition of DEFAULT_TOOLBAR spread plus table-up button append. Applied across three editor initializations (editorBox, editorLine, editorScale).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A toolbar once custom and grand,
Now simplified, sparse, and refined,
Defaults compose what defaults command,
Cleaner configs of every kind,
Demo files hop into the light! 🌟

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kagol/fix-table-demo

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b3fba7b and bf96ada.

📒 Files selected for processing (3)
  • packages/docs/fluent-editor/demos/i18n.vue
  • packages/docs/fluent-editor/demos/mind-map-resize.vue
  • packages/docs/fluent-editor/demos/table-up-resize.vue

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants