fix: Fix i18n test

[lu-yg]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Documentation

  • Updated method descriptions to clarify that i18n entries are retrieved by app.

• Tests

  • Renamed and updated test cases to reflect retrieval of i18n entries by app.

[coderabbitai]

Walkthrough

The changes update the Javadoc and annotation descriptions for a controller method to clarify that i18n entries are fetched by app. The related test method is renamed and updated to reflect the new method invocation and parameters, aligning the test with the controller's intended usage.

Changes

File(s)	Change Summary
base/src/main/java/com/tinyengine/it/controller/I18nEntryController.java	Updated Javadoc and annotation description for the method to specify fetching i18n entries by app.
base/src/test/java/com/tinyengine/it/controller/I18nEntryControllerTest.java	Renamed and updated test method to call the controller with explicit parameters for fetching i18n entries by app.

Poem

In code we hop, from test to doc,
Clarifying how our entries unlock.
By app we fetch, with purpose clear,
The tests align, the changes near.
With every tweak, our meaning grows—
A rabbit’s joy in what it knows! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1cd40f2 and 4c3e1f2.

📒 Files selected for processing (2)

• base/src/main/java/com/tinyengine/it/controller/I18nEntryController.java (2 hunks)
• base/src/test/java/com/tinyengine/it/controller/I18nEntryControllerTest.java (1 hunks)

🔇 Additional comments (6)

base/src/main/java/com/tinyengine/it/controller/I18nEntryController.java (4)

73-73: LGTM: Documentation improvement for clarity.

The Javadoc update removes "all" from the description, making it more accurate to reflect that this method retrieves i18n entries specifically by app, not all entries in the system.

---

82-82: LGTM: Annotation description clarification.

The updated annotation description adds "通过app" (by app) to clarify the specific scope of this operation, improving the logging context.

---

73-73: LGTM: Accurate Javadoc improvement.

Removing "all" from the Javadoc comment is correct since the method filters i18n entries by app parameters rather than returning all entries.

---

82-82: LGTM: Consistent annotation description.

Adding "通过app" (by app) to the SystemControllerLog description makes it consistent with the method's actual behavior and aligns with the updated Javadoc comment.

base/src/test/java/com/tinyengine/it/controller/I18nEntryControllerTest.java (2)

61-68: LGTM: Test method properly aligned with controller implementation.

Excellent fix! The test method has been correctly updated to:

• Use the actual controller method name getI18nEntriesByApp
• Mock the correct service method findI18nEntryByApp(anyInt(), anyString())
• Pass the required parameters (host and hostType)

This resolves the test alignment issue and ensures the test validates the actual controller behavior.

---

61-66: LGTM: Critical test fix that aligns test with actual implementation.

This change fixes a broken test by:

1. Correcting method name: testGetAllI18nEntries → testGetI18nEntriesByApp to match the actual controller method
2. Fixing mock setup: findAllI18nEntry() → findI18nEntryByApp(anyInt(), anyString()) to match the actual service call
3. Adding proper parameters: Now provides host=1 and hostType="app" as required by the method signature
4. Calling correct method: getI18nEntriesByApp(host, hostType) instead of the non-existent getAllI18nEntries()

The test now accurately tests the existing controller functionality rather than attempting to test methods that don't exist.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.