-
Notifications
You must be signed in to change notification settings - Fork 84
fix: prevent SQL injection in model-data API #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d9c3642
fix: prevent SQL injection in model-data API via identifier validation
hexqi 187cc88
fix: add model metadata whitelist validation to DynamicModelService
hexqi 712af3a
fix: resolve circular dependency between DynamicModelService and Mode…
hexqi 669d2aa
fix: make orderType and orderBy case-insensitive across validation la…
hexqi afdb1e5
fix: allow queryWithPage with null/empty params for list-all queries
hexqi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
35 changes: 35 additions & 0 deletions
35
base/src/main/java/com/tinyengine/it/common/utils/SqlIdentifierValidator.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package com.tinyengine.it.common.utils; | ||
|
|
||
| import java.util.List; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public class SqlIdentifierValidator { | ||
|
|
||
| private static final Pattern IDENTIFIER_PATTERN = | ||
| Pattern.compile("^[a-zA-Z_][a-zA-Z0-9_]*$"); | ||
|
|
||
| private static final Pattern ORDER_TYPE_PATTERN = | ||
| Pattern.compile("^(ASC|DESC)$", Pattern.CASE_INSENSITIVE); | ||
|
|
||
| private SqlIdentifierValidator() { | ||
| } | ||
|
|
||
| public static void validate(String identifier) { | ||
| if (identifier == null || !IDENTIFIER_PATTERN.matcher(identifier).matches()) { | ||
| throw new IllegalArgumentException("Invalid SQL identifier: " + identifier); | ||
| } | ||
| } | ||
|
|
||
| public static void validateAll(List<String> identifiers) { | ||
| if (identifiers == null) { | ||
| return; | ||
| } | ||
| identifiers.forEach(SqlIdentifierValidator::validate); | ||
| } | ||
|
|
||
| public static void validateOrderType(String orderType) { | ||
| if (orderType == null || !ORDER_TYPE_PATTERN.matcher(orderType).matches()) { | ||
| throw new IllegalArgumentException("Invalid order type: " + orderType); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.