Skip to content

feat: remove cloud#122

Merged
kagol merged 1 commit intodevfrom
kagol/remove-cloud
Oct 21, 2025
Merged

feat: remove cloud#122
kagol merged 1 commit intodevfrom
kagol/remove-cloud

Conversation

@kagol
Copy link
Member

@kagol kagol commented Oct 21, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Removed Features
    • Removed Cloud service capability module including Hello World example and Contracts management features from the menu structure and application routes.
    • Removed Huawei Cloud API integration and related service configuration.
    • Removed associated cloud-related localization strings and user interface components for the deleted features.

@github-actions github-actions bot added the enhancement New feature or request label Oct 21, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes remove all cloud-related features from both NestJS and TinyVue templates, eliminating Huawei Cloud (HWC) client integration, menu items, routing, cloud views, services, dependencies, and locale strings. This represents a complete feature purge affecting backend configuration and frontend UI components, services, and dependencies.

Changes

Cohort / File(s) Summary
NestJS Menu Configuration
template/nestJs/src/menu/init/menuData.ts, template/nestJs/src/menu/menu.service.ts
Removed three menu items (Cloud, Hello, Contracts) from menuData export; updated parentId assignments in handleMenuParentId logic, consolidating and reparenting multiple nodes.
TinyVue Dependencies & Configuration
template/tinyvue/package.json, template/tinyvue/hwc-exports.json, template/tinyvue/src/locales.json
Removed @opentiny/hwc-client dependency; deleted hwc-exports.json (static HWC configuration with API, function configs); removed all cloud-related locale entries (enUS, zhCN).
TinyVue Application Setup
template/tinyvue/src/main.ts, template/tinyvue/src/App.vue
Removed HwcClient import and initialization; removed HwcClient configuration call; removed echarts import.
TinyVue Routing
template/tinyvue/src/router/routes/modules/cloud.ts
Deleted entire Cloud route module with child routes (Hello, Contracts) and associated metadata.
TinyVue Services
template/tinyvue/src/utils/hwcClient.service.ts, template/tinyvue/src/views/cloud/contracts/hwcClient.service.ts
Removed HwcClientService class and static apiRequest method from both utility and contracts-specific service files.
TinyVue Cloud Views & Components
template/tinyvue/src/views/cloud/index.vue, template/tinyvue/src/views/cloud/hello/index.vue, template/tinyvue/src/views/cloud/contracts/index.vue, template/tinyvue/src/views/cloud/contracts/components/(create|delete|edit)/index.vue
Removed all cloud-related Vue components: main cloud layout, hello world page, contract management page with CRUD forms (create, edit, delete modals).

Sequence Diagram(s)

sequenceDiagram
    actor User
    participant App as App.vue
    participant Router as Router
    participant HWC as HwcClient<br/>(Removed)
    
    User->>App: Navigate
    Note over App: Before: Import echarts<br/>After: Import removed
    
    alt Before
        App->>Router: Initialize routes
        Router->>Router: Load Cloud routes
        Router->>HWC: Configure HwcClient
        HWC->>HWC: Initialize config
    else After (Current)
        App->>Router: Initialize routes
        Router->>Router: Cloud routes deleted
        Note over App: HwcClient initialization removed
        Note over Router: Cloud module not loaded
    end
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

The review requires verification across heterogeneous file types (configuration, routing, components, services, dependencies), validation that menu hierarchy changes are correct, confirmation that all HWC client references are properly removed, and checks for orphaned imports or component dependencies.

Poem

🐰 The cloud has drifted far away,
No more hello worlds here to stay,
Contracts filed, components gone,
Menu trails now carry on,
The hwc client takes its leave—
Cleaner code, we do believe! 🌟

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kagol/remove-cloud

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ccb360 and fe6dc05.

⛔ Files ignored due to path filters (2)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • template/tinyvue/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (16)
  • template/nestJs/src/menu/init/menuData.ts (0 hunks)
  • template/nestJs/src/menu/menu.service.ts (1 hunks)
  • template/tinyvue/hwc-exports.json (0 hunks)
  • template/tinyvue/package.json (0 hunks)
  • template/tinyvue/src/App.vue (0 hunks)
  • template/tinyvue/src/locales.json (0 hunks)
  • template/tinyvue/src/main.ts (0 hunks)
  • template/tinyvue/src/router/routes/modules/cloud.ts (0 hunks)
  • template/tinyvue/src/utils/hwcClient.service.ts (0 hunks)
  • template/tinyvue/src/views/cloud/contracts/components/create/index.vue (0 hunks)
  • template/tinyvue/src/views/cloud/contracts/components/delete/index.vue (0 hunks)
  • template/tinyvue/src/views/cloud/contracts/components/edit/index.vue (0 hunks)
  • template/tinyvue/src/views/cloud/contracts/hwcClient.service.ts (0 hunks)
  • template/tinyvue/src/views/cloud/contracts/index.vue (0 hunks)
  • template/tinyvue/src/views/cloud/hello/index.vue (0 hunks)
  • template/tinyvue/src/views/cloud/index.vue (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kagol kagol merged commit de6f791 into dev Oct 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments