-
Notifications
You must be signed in to change notification settings - Fork 18
fix: Modify UI Ireview comments #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis update removes specific CSS classes and scoped style blocks from several Vue components. Horizontal padding classes are eliminated from a layout wrapper, and LESS style blocks applying margins to Changes
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
template/tinyvue/src/layout/default-layout.vue (1)
11-14: Removal ofpl-[10px] pr-[10px]risks edge-to-edge contentHorizontal padding was stripped from the main content wrapper. On wide screens the first column of content may now butt up against the left menu shadow and the scrollbar on the right, which looks cramped and can clip box-shadows.
If this was intentional, ignore. Otherwise, re-add padding via utility classes or a layout-wide CSS var so styling stays consistent:
-<div class="text-[#ccc] bg-[#f5f6f7] flex-1 h-[calc(100vh-60px)]" +<div class="text-[#ccc] bg-[#f5f6f7] flex-1 h-[calc(100vh-60px)] pl-[10px] pr-[10px]"(or a LESS variable if utilities are being phased out).
Test in collapsed and expanded menu modes to confirm nothing overlaps.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
template/tinyvue/src/layout/default-layout.vue(1 hunks)template/tinyvue/src/views/form/step/components/coach-form.vue(1 hunks)template/tinyvue/src/views/form/step/index.vue(0 hunks)template/tinyvue/src/views/user/setting/components/set-from.vue(0 hunks)
💤 Files with no reviewable changes (2)
- template/tinyvue/src/views/user/setting/components/set-from.vue
- template/tinyvue/src/views/form/step/index.vue
🔇 Additional comments (1)
template/tinyvue/src/views/form/step/components/coach-form.vue (1)
220-224: Confirm layout after dropping the scoped.tiny-rowmargin ruleThe scoped
<style>block that previously setmargin-bottom: 15pxfor every.tiny-rowis now gone.
Every<tiny-row>inside this form is stacked vertically, so the visual spacing between the two row blocks (lines 12-61 and 63-108) now depends entirely on the default styles coming from@opentiny/vue. On several themes that default is0, which can lead to the two blocks sticking together.Before merging, open the page and ensure the two row groups still have the intended vertical gap on all supported themes / break-points. If the gap is gone, consider:
+<tiny-row :flex="true" class="mb-[15px]">or use the grid’s native
gutterprop for a cleaner solution.
PR
fix:UI检视意见修改
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit