Conversation
…e in History component props
WalkthroughAdds a new 0.3.0-rc.5 release notes block to docs and bumps package versions ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (7)
packages/components/package.json (1)
29-41: Tooling drift across packages; consider aligning Vite/TS plugin versions.Dev toolchain here uses vite ^5.0.8 with @vitejs/plugin-vue ^4.5.2. Plugin v4 targets Vite 4; for Vite 5, plugin-vue v5 is recommended. Also TS is ^5.2.2 here but other packages use ~5.7.x and ^5.8.x. Consider harmonizing to reduce inter-package DTS and build differences.
Apply:
- "@vitejs/plugin-vue": "^4.5.2", + "@vitejs/plugin-vue": "^5.0.0", - "typescript": "^5.2.2", + "typescript": "~5.7.2",And align the same baseline across packages if feasible.
packages/svgs/package.json (1)
27-37: Minor: lock esbuild to a caret range to ease patch updates.Pinned 0.21.5 works, but caret pinning avoids manual bumps for compatible patches.
- "esbuild": "0.21.5", + "esbuild": "^0.21.5",packages/kit/package.json (1)
21-25: TypeScript version baseline differs from other packages.Kit uses TS ^5.8.2 while components/svgs use older minors. Consider a single TS baseline to prevent DTS incompatibilities across packages.
docs/src/releases/update-log.md (4)
6-8: Add deeplink to the changed History Props docs.“请参考文档” without a link slows adoption. Add a direct anchor to the History component’s Props section.
Example:
-> **Breaking Change**: History 历史组件 Props 参数变更,请参考文档 +> **Breaking Change**: History 历史组件 Props 参数变更,请参考[文档](../components/history#props)
4-4: Confirm admonition syntax renders in your site.
> [!IMPORTANT]is GitHub-flavored; VitePress typically uses::: warning. If your pipeline doesn’t transform GH admonitions, switch syntax to avoid rendering as plain blockquotes.
11-24: Minor copy/formatting consistency.Component/prop names are sometimes in backticks and sometimes not. Wrap all identifiers (Bubble, History, Sender, Props names like upload-popper-class) for consistent styling and searchability.
28-32: Changelog actionable detail.For “新增消息完成原因支持”, briefly name the enum/string values (e.g., “stop”, “length”, “content_filter”, etc.) if applicable, so users can scan for exact additions.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs/src/releases/update-log.md(1 hunks)packages/components/package.json(1 hunks)packages/kit/package.json(1 hunks)packages/svgs/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e-tests
🔇 Additional comments (4)
packages/svgs/package.json (1)
3-3: Version bump OK.No other changes; publishConfig/type/files/scripts remain consistent with prior releases.
packages/kit/package.json (1)
3-3: Version bump matches rc.5 plan.Looks consistent with components and svgs.
Include this package when publishing: confirm npm dist-tags for the three packages point to rc.5 after release.
docs/src/releases/update-log.md (1)
35-39: Docs and package versions alignment.Ensure the site header/footer version badges (if any) and install snippets reflect rc.5 on publish day (September 18, 2025).
packages/components/package.json (1)
3-3: Version bump looks good — confirm lockfile & no stale refspackages/* package.json are at 0.3.0-rc.5; script error prevented verifying lockfile and repo-wide refs. Confirm pnpm-lock.yaml / package-lock.json / yarn.lock contain 0.3.0-rc.5 and that no 0.3.0-rc.4 references remain.
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation
Chores