Skip to content

feat(sender): replace wave image with IconRecordingWave icon#284

Merged
hexqi merged 2 commits intoopentiny:release/v0.3.xfrom
SonyLeo:feat/lazy-load-resource
Jan 14, 2026
Merged

feat(sender): replace wave image with IconRecordingWave icon#284
hexqi merged 2 commits intoopentiny:release/v0.3.xfrom
SonyLeo:feat/lazy-load-resource

Conversation

@SonyLeo
Copy link
Collaborator

@SonyLeo SonyLeo commented Jan 14, 2026

替换 sender 组件语音 录制中 的按钮

Summary by CodeRabbit

  • Refactor

    • Replaced recording indicator implementation with an enhanced visual component for improved consistency and alignment with the application's design system.
  • Style

    • Removed legacy CSS styling rules for the recording state, streamlining the codebase.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Walkthrough

The recording indicator in ActionButtons.vue was refactored to use the IconRecordingWave Vue component from @opentiny/tiny-robot-svgs instead of a static image file, with corresponding CSS cleanup.

Changes

Cohort / File(s) Summary
Recording Indicator Component Replacement
packages/components/src/sender/components/ActionButtons.vue
Replaced static wave.webp image with IconRecordingWave Vue component; added import from '@opentiny/tiny-robot-svgs'; removed associated CSS styling (.action-buttons__recording)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A wave once frozen in time so still,
Now dances with Vue magic and will,
The icon component brings it to life,
Smooth animated motion, no CSS strife! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: replacing a wave image with the IconRecordingWave icon component in the sender module.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 67a16b1 and 332de37.

⛔ Files ignored due to path filters (1)
  • packages/svgs/src/assets/recording-wave.svg is excluded by !**/*.svg
📒 Files selected for processing (1)
  • packages/components/src/sender/components/ActionButtons.vue
🔇 Additional comments (2)
packages/components/src/sender/components/ActionButtons.vue (2)

5-5: LGTM!

The IconRecordingWave import is correctly added alongside the other icon imports from @opentiny/tiny-robot-svgs, following the existing import pattern.


224-225: Clean refactor from image to icon component.

The replacement follows the established pattern used by other icons in this file. Using IconRecordingWave from the shared SVG library improves consistency and maintainability compared to the previous static image approach.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

❌ Deploy failed. Please check the logs for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

@SonyLeo SonyLeo marked this pull request as ready for review January 14, 2026 04:02
@hexqi hexqi merged commit a467117 into opentiny:release/v0.3.x Jan 14, 2026
4 checks passed
@github-actions
Copy link
Contributor

🧹 Preview Cleaned Up

The preview deployment has been removed.

@SonyLeo SonyLeo deleted the feat/lazy-load-resource branch January 15, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants