chore: [charts]rename chart-core packages to huicharts-core #2002
Conversation
WalkthroughThe updates involve a significant rebranding of various Vue charting packages, changing their names from the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant ChartLibrary as Old Chart Library
participant NewChartLibrary as New Chart Library
User->>App: Request to display chart
App->>Old Chart Library: Fetch chart component
Old Chart Library-->>App: Return chart component
App-->>User: Display chart
User->>App: Request to display chart
App->>NewChartLibrary: Fetch chart component
NewChartLibrary-->>App: Return chart component
App-->>User: Display chart
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (3)
packages/vue/src/chart/chart-gauge/package.json (1)
15-15: Inconsistency in Dependency UpdateThe dependency
@opentiny/vue-chart-corehas been correctly updated to@opentiny/vue-huicharts-corein mostpackage.jsonfiles. However, theautonavi-map/package.jsonfile still references the old dependency. Please update this file to ensure consistency across the monorepo.
packages/vue/src/chart/autonavi-map/package.json: Update@opentiny/vue-chart-coreto@opentiny/vue-huicharts-core.Analysis chain
Dependency name updated correctly.
The dependency
@opentiny/vue-chart-corehas been correctly updated to@opentiny/vue-huicharts-core. Ensure that the version specified as "workspace:~" is correctly set up in your monorepo configuration to avoid any build or dependency resolution issues.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the workspace configuration for the new dependency. # Test: Search for workspace configuration in package.json files. Expect: Correct setup for `@opentiny/vue-huicharts-core`. rg --type json -A 5 $'workspace:~' packages/vue/src/chart/*/package.jsonLength of output: 10429
packages/vue/src/chart/chart-boxplot/package.json (1)
15-15: Inconsistency in Dependency UpdateThe dependency
@opentiny/vue-huicharts-corehas been correctly updated in mostpackage.jsonfiles with the version "workspace:~". However, the old dependency@opentiny/vue-chart-coreis still present inautonavi-map/package.json. Please verify if this is intentional or if it needs to be updated as well.
autonavi-map/package.json: Contains@opentiny/vue-chart-coreinstead of@opentiny/vue-huicharts-core.Analysis chain
Dependency name updated correctly.
The dependency
@opentiny/vue-chart-corehas been correctly updated to@opentiny/vue-huicharts-core. Ensure that the version specified as "workspace:~" is correctly set up in your monorepo configuration to avoid any build or dependency resolution issues.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the workspace configuration for the new dependency. # Test: Search for workspace configuration in package.json files. Expect: Correct setup for `@opentiny/vue-huicharts-core`. rg --type json -A 5 $'workspace:~' packages/vue/src/chart/*/package.jsonLength of output: 10429
packages/vue/src/chart/chart-heatmap/package.json (1)
15-15: Dependency update verified for chart-heatmap, but check autonavi-map package.The dependency
@opentiny/vue-huicharts-corehas been correctly updated in thechart-heatmappackage. However, theautonavi-mappackage still references@opentiny/vue-chart-core. Please verify if this is intentional or if it needs updating.
chart-heatmap/package.json: Correct update to@opentiny/vue-huicharts-core.autonavi-map/package.json: Still uses@opentiny/vue-chart-core.Analysis chain
Dependency name updated correctly.
The dependency
@opentiny/vue-chart-corehas been correctly updated to@opentiny/vue-huicharts-core. Ensure that the version specified as "workspace:~" is correctly set up in your monorepo configuration to avoid any build or dependency resolution issues.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the workspace configuration for the new dependency. # Test: Search for workspace configuration in package.json files. Expect: Correct setup for `@opentiny/vue-huicharts-core`. rg --type json -A 5 $'workspace:~' packages/vue/src/chart/*/package.jsonLength of output: 10429
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (27)
- packages/modules.json (2 hunks)
- packages/vue/src/chart/autonavi-map/package.json (1 hunks)
- packages/vue/src/chart/baidu-map/package.json (2 hunks)
- packages/vue/src/chart/chart-bar/package.json (2 hunks)
- packages/vue/src/chart/chart-boxplot/package.json (2 hunks)
- packages/vue/src/chart/chart-candle/package.json (2 hunks)
- packages/vue/src/chart/chart-core/package.json (1 hunks)
- packages/vue/src/chart/chart-funnel/package.json (2 hunks)
- packages/vue/src/chart/chart-gauge/package.json (2 hunks)
- packages/vue/src/chart/chart-graph/package.json (2 hunks)
- packages/vue/src/chart/chart-heatmap/package.json (2 hunks)
- packages/vue/src/chart/chart-histogram/package.json (2 hunks)
- packages/vue/src/chart/chart-line/package.json (2 hunks)
- packages/vue/src/chart/chart-liquidfill/package.json (2 hunks)
- packages/vue/src/chart/chart-map/package.json (2 hunks)
- packages/vue/src/chart/chart-pie/package.json (2 hunks)
- packages/vue/src/chart/chart-process/package.json (2 hunks)
- packages/vue/src/chart/chart-radar/package.json (2 hunks)
- packages/vue/src/chart/chart-ring/package.json (2 hunks)
- packages/vue/src/chart/chart-sankey/package.json (2 hunks)
- packages/vue/src/chart/chart-scatter/package.json (2 hunks)
- packages/vue/src/chart/chart-sunburst/package.json (2 hunks)
- packages/vue/src/chart/chart-tree/package.json (2 hunks)
- packages/vue/src/chart/chart-waterfall/package.json (2 hunks)
- packages/vue/src/chart/chart-wordcloud/package.json (2 hunks)
- packages/vue/src/chart/package.json (2 hunks)
- packages/vue/src/chart/src/index.ts (1 hunks)
Files skipped from review due to trivial changes (12)
- packages/vue/src/chart/autonavi-map/package.json
- packages/vue/src/chart/chart-candle/package.json
- packages/vue/src/chart/chart-core/package.json
- packages/vue/src/chart/chart-funnel/package.json
- packages/vue/src/chart/chart-graph/package.json
- packages/vue/src/chart/chart-pie/package.json
- packages/vue/src/chart/chart-radar/package.json
- packages/vue/src/chart/chart-sankey/package.json
- packages/vue/src/chart/chart-scatter/package.json
- packages/vue/src/chart/chart-sunburst/package.json
- packages/vue/src/chart/chart-tree/package.json
- packages/vue/src/chart/package.json
Additional comments not posted (26)
packages/vue/src/chart/chart-bar/package.json (2)
2-2: Package name updated correctly.The package name change from
@opentiny/vue-chart-barto@opentiny/vue-huicharts-baris consistent with the PR objectives and is correctly implemented.
15-15: Dependency updated correctly.The update of the dependency from
@opentiny/vue-chart-coreto@opentiny/vue-huicharts-coreis necessary for compatibility with the renamed core package and is correctly implemented.packages/vue/src/chart/chart-map/package.json (2)
2-2: Package name updated correctly.The package name change from
@opentiny/vue-chart-mapto@opentiny/vue-huicharts-mapis consistent with the PR objectives and is correctly implemented.
15-15: Dependency updated correctly.The update of the dependency from
@opentiny/vue-chart-coreto@opentiny/vue-huicharts-coreis necessary for compatibility with the renamed core package and is correctly implemented.packages/vue/src/chart/chart-line/package.json (2)
2-2: Package name updated correctly.The package name change from
@opentiny/vue-chart-lineto@opentiny/vue-huicharts-lineis consistent with the PR objectives and is correctly implemented.
15-15: Dependency updated correctly.The update of the dependency from
@opentiny/vue-chart-coreto@opentiny/vue-huicharts-coreis necessary for compatibility with the renamed core package and is correctly implemented.packages/vue/src/chart/chart-gauge/package.json (1)
2-2: Package name updated correctly.The package name has been updated to
@opentiny/vue-huicharts-gaugewhich aligns with the rebranding objectives of the PR.packages/vue/src/chart/chart-boxplot/package.json (1)
2-2: Package name updated correctly.The package name has been updated to
@opentiny/vue-huicharts-boxplotwhich aligns with the rebranding objectives of the PR.packages/vue/src/chart/chart-heatmap/package.json (1)
2-2: Package name updated correctly.The package name has been updated to
@opentiny/vue-huicharts-heatmapwhich aligns with the rebranding objectives of the PR.packages/vue/src/chart/chart-process/package.json (2)
2-2: Package name updated correctly.The new package name
@opentiny/vue-huicharts-processaligns with the PR's objectives to standardize the naming convention.
15-15: Dependency name updated correctly.The updated dependency name
@opentiny/vue-huicharts-corereflects the new naming convention and is consistent with the changes made to the package name.packages/vue/src/chart/chart-histogram/package.json (2)
2-2: Package name updated correctly.The new package name
@opentiny/vue-huicharts-histogramaligns with the PR's objectives to standardize the naming convention.
15-15: Dependency name updated correctly.The updated dependency name
@opentiny/vue-huicharts-corereflects the new naming convention and is consistent with the changes made to the package name.packages/vue/src/chart/chart-wordcloud/package.json (2)
2-2: Package name updated correctly.The new package name
@opentiny/vue-huicharts-wordcloudaligns with the PR's objectives to standardize the naming convention.
15-15: Dependency name updated correctly.The updated dependency name
@opentiny/vue-huicharts-corereflects the new naming convention and is consistent with the changes made to the package name.packages/vue/src/chart/chart-liquidfill/package.json (2)
2-2: Package name updated correctly.The new package name
@opentiny/vue-huicharts-liquidfillaligns with the rebranding strategy outlined in the PR.
15-15: Dependency updated correctly.The dependency on
@opentiny/vue-huicharts-coreis updated to reflect the new package naming, maintaining consistency across the project.packages/vue/src/chart/chart-ring/package.json (2)
2-2: Package name updated correctly.The new package name
@opentiny/vue-huicharts-ringaligns with the rebranding strategy outlined in the PR.
15-15: Dependency updated correctly.The dependency on
@opentiny/vue-huicharts-coreis updated to reflect the new package naming, maintaining consistency across the project.packages/vue/src/chart/chart-waterfall/package.json (2)
2-2: Package name updated correctly.The new package name
@opentiny/vue-huicharts-waterfallaligns with the rebranding strategy outlined in the PR.
15-15: Dependency updated correctly.The dependency on
@opentiny/vue-huicharts-coreis updated to reflect the new package naming, maintaining consistency across the project.packages/vue/src/chart/baidu-map/package.json (2)
2-2: Package name updated correctly.The new package name
@opentiny/vue-huicharts-bmapaligns with the project's rebranding efforts.The change is correctly implemented and follows the new naming convention.
18-18: Dependency updated correctly.The dependency name change to
@opentiny/vue-huicharts-coreis consistent with the new package naming convention.The change is correctly implemented and follows the new naming convention.
packages/vue/src/chart/src/index.ts (1)
1-26: Imports updated correctly.All import statements have been correctly updated to reflect the new
huichartsnamespace, aligning with the project's rebranding efforts.The changes are correctly implemented and follow the new naming convention.
packages/modules.json (2)
87-91: New module entry added: "AnchorMobileFirst"The entry for
"AnchorMobileFirst"is added correctly with appropriate attributes (path,type,exclude). The path points to a Vue template, which aligns with the type specified. This addition seems to align with the project's structure and naming conventions.
1473-1477: New module entry added: "Hooks"The entry for
"Hooks"is added correctly, pointing to a TypeScript module. This addition enhances the project by potentially introducing new functionality related to Vue hooks. The path and type attributes are consistent with the project's standards.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (63)
- examples/sites/demos/pc/app/chart/boxplot/vertical.vue (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-attributes-demo.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-attributes-demo.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-autonavi-map.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-autonavi-map.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-baidu-map.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-baidu-map.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-bar.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-bar.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-boxplot.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-boxplot.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-candle.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-candle.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-events.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-events.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-funnel.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-funnel.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-gauge.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-gauge.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-graph.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-graph.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-heatmap.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-heatmap.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-histogram.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-histogram.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-line.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-line.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-liquidfill.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-liquidfill.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-map.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-map.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-pie.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-pie.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-process.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-process.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-question.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-question.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-radar.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-radar.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-ring.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-ring.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-sankey.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-sankey.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-scatter.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-scatter.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-sunburst.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-sunburst.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-tree.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-tree.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-waterfall.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-waterfall.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-wordcloud.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart-wordcloud.json.cn.md (1 hunks)
- examples/sites/demos/pc/app/chart/webdoc/chart.cn.md (1 hunks)
- packages/vue/src/chart/autonavi-map/package.json (2 hunks)
- packages/vue/src/chart/autonavi-map/src/autonavi-map.vue (1 hunks)
- packages/vue/src/chart/baidu-map/src/baidu-map.vue (1 hunks)
- packages/vue/src/chart/chart-bar/src/chart-bar.vue (1 hunks)
- packages/vue/src/chart/chart-bar/src/histogram.ts (1 hunks)
- packages/vue/src/chart/chart-boxplot/src/boxplot.ts (1 hunks)
- packages/vue/src/chart/chart-boxplot/src/chart-boxplot.vue (1 hunks)
- packages/vue/src/chart/chart-candle/src/candle.ts (1 hunks)
- packages/vue/src/chart/chart-candle/src/chart-candle.vue (1 hunks)
Files skipped from review due to trivial changes (4)
- examples/sites/demos/pc/app/chart/boxplot/vertical.vue
- packages/vue/src/chart/autonavi-map/src/autonavi-map.vue
- packages/vue/src/chart/chart-bar/src/chart-bar.vue
- packages/vue/src/chart/chart-candle/src/candle.ts
Files skipped from review as they are similar to previous changes (1)
- packages/vue/src/chart/autonavi-map/package.json
Additional comments not posted (127)
examples/sites/demos/pc/app/chart/webdoc/chart-attributes-demo.cn.md (3)
7-7: LGTM!The warning about the upcoming removal of the Chart component is clear and informative.
The code changes are approved.
8-8: LGTM!The empty line improves readability.
The code changes are approved.
9-9: LGTM!The description highlighting the features of the Chart component is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-attributes-demo.json.cn.md (3)
7-7: LGTM!The warning about the upcoming removal of the Chart component is clear and informative.
The code changes are approved.
8-8: LGTM!The empty line improves readability.
The code changes are approved.
9-9: LGTM!The description highlighting the features of the Chart component is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-autonavi-map.cn.md (3)
7-7: LGTM!The warning about the upcoming removal of the Chart component is clear and informative.
The code changes are approved.
8-8: LGTM!The empty line improves readability.
The code changes are approved.
9-9: LGTM!The description highlighting the features of the Chart component is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-autonavi-map.json.cn.md (3)
7-7: LGTM!The warning about the future removal of the Chart component is clear and provides necessary information.
The change is approved.
8-8: LGTM!The empty line improves readability and separates the warning from the description.
The change is approved.
9-9: LGTM!The expanded description provides valuable information about the features of the Chart component.
The change is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-baidu-map.cn.md (3)
7-7: LGTM!The warning about the future removal of the Chart component is clear and provides necessary information.
The change is approved.
8-8: LGTM!The empty line improves readability and separates the warning from the description.
The change is approved.
9-9: LGTM!The expanded description provides valuable information about the features of the Chart component.
The change is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-baidu-map.json.cn.md (3)
7-7: LGTM!The warning about the future removal of the Chart component is clear and provides necessary information.
The change is approved.
8-8: LGTM!The empty line improves readability and separates the warning from the description.
The change is approved.
9-9: LGTM!The expanded description provides valuable information about the features of the Chart component.
The change is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-bar.cn.md (2)
7-7: LGTM!The warning about the future removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The description of the Chart component's features is clear and comprehensive.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-bar.json.cn.md (2)
7-7: LGTM!The warning about the future removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The description of the Chart component's features is clear and comprehensive.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-boxplot.cn.md (2)
7-7: LGTM!The warning about the future removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The description of the Chart component's features is clear and comprehensive.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-boxplot.json.cn.md (2)
7-7: LGTM!The warning about the upcoming removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The enhanced description of the Chart component is informative and highlights its key features.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-candle.cn.md (2)
7-7: LGTM!The warning about the upcoming removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The enhanced description of the Chart component is informative and highlights its key features.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-candle.json.cn.md (2)
7-7: LGTM!The warning about the upcoming removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The enhanced description of the Chart component is informative and highlights its key features.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-events.cn.md (2)
7-7: LGTM!The warning about the removal of the Chart component is clear and provides necessary information to the users.
The changes are approved.
9-9: LGTM!The enhanced description of the Chart component provides a clearer understanding of its functionalities.
The changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-events.json.cn.md (2)
7-7: LGTM!The warning about the removal of the Chart component is clear and provides necessary information to the users.
The changes are approved.
9-9: LGTM!The enhanced description of the Chart component provides a clearer understanding of its functionalities.
The changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-funnel.cn.md (2)
7-7: LGTM!The warning about the removal of the Chart component is clear and provides necessary information to the users.
The changes are approved.
9-9: LGTM!The enhanced description of the Chart component provides a clearer understanding of its functionalities.
The changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-funnel.json.cn.md (2)
7-7: LGTM!The warning note is clear and provides essential information to the users.
The code changes are approved.
9-9: LGTM!The expanded description is informative and enhances the clarity of the component's usage and future changes.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-gauge.cn.md (2)
7-7: LGTM!The warning note is clear and provides essential information to the users.
The code changes are approved.
9-9: LGTM!The expanded description is informative and enhances the clarity of the component's usage and future changes.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-gauge.json.cn.md (2)
7-7: LGTM!The warning note is clear and provides essential information to the users.
The code changes are approved.
9-9: LGTM!The expanded description is informative and enhances the clarity of the component's usage and future changes.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-graph.cn.md (3)
7-7: LGTM!The notice about the future removal of the Chart component is clear and informative.
The addition is approved.
8-8: LGTM!The empty line improves readability.
The addition is approved.
9-9: LGTM!The description of the Chart component's features is clear and informative.
The addition is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-graph.json.cn.md (3)
7-7: LGTM!The notice about the future removal of the Chart component is clear and informative.
The addition is approved.
8-8: LGTM!The empty line improves readability.
The addition is approved.
9-9: LGTM!The description of the Chart component's features is clear and informative.
The addition is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-heatmap.cn.md (3)
7-7: LGTM!The notice about the future removal of the Chart component is clear and informative.
The addition is approved.
8-8: LGTM!The empty line improves readability.
The addition is approved.
9-9: LGTM!The description of the Chart component's features is clear and informative.
The addition is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-heatmap.json.cn.md (3)
7-7: LGTM!The warning note provides important information about the future removal of the Chart component.
The addition is approved.
8-8: LGTM!The empty line improves readability by separating the warning note from the description.
The addition is approved.
9-9: LGTM!The expanded description provides valuable information about the features of the Chart component.
The addition is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-histogram.cn.md (3)
7-7: LGTM!The warning note provides important information about the future removal of the Chart component.
The addition is approved.
8-8: LGTM!The empty line improves readability by separating the warning note from the description.
The addition is approved.
9-9: LGTM!The expanded description provides valuable information about the features of the Chart component.
The addition is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-histogram.json.cn.md (3)
7-7: LGTM!The warning note provides important information about the future removal of the Chart component.
The addition is approved.
8-8: LGTM!The empty line improves readability by separating the warning note from the description.
The addition is approved.
9-9: LGTM!The expanded description provides valuable information about the features of the Chart component.
The addition is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-line.cn.md (2)
7-7: LGTM!The notice about the future removal of the Chart component and its separate import is clear and informative.
The code changes are approved.
9-9: LGTM!The expanded description of the Chart component's features is comprehensive and enhances the clarity of the documentation.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-line.json.cn.md (2)
7-7: LGTM!The notice about the future removal of the Chart component and its separate import is clear and informative.
The code changes are approved.
9-9: LGTM!The expanded description of the Chart component's features is comprehensive and enhances the clarity of the documentation.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-liquidfill.cn.md (2)
7-7: LGTM!The notice about the future removal of the Chart component and its separate import is clear and informative.
The code changes are approved.
9-9: LGTM!The expanded description of the Chart component's features is comprehensive and enhances the clarity of the documentation.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-liquidfill.json.cn.md (2)
7-7: LGTM!The warning about the upcoming removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The description highlighting the features of the Chart component is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-map.cn.md (2)
7-7: LGTM!The warning about the upcoming removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The description highlighting the features of the Chart component is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-map.json.cn.md (2)
7-7: LGTM!The warning about the upcoming removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The description highlighting the features of the Chart component is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-pie.cn.md (2)
7-7: LGTM!The warning about the upcoming removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The description of the features of the Chart component is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-pie.json.cn.md (2)
7-7: LGTM!The warning about the upcoming removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The description of the features of the Chart component is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-process.cn.md (2)
7-7: LGTM!The warning about the upcoming removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The description of the features of the Chart component is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-process.json.cn.md (2)
7-7: LGTM!The notice about the Chart component removal and its new import path is clear and informative.
The change is approved.
9-9: LGTM!The description of the Chart component's features is clear and informative.
The change is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-question.cn.md (2)
7-7: LGTM!The notice about the Chart component removal and its new import path is clear and informative.
The change is approved.
9-9: LGTM!The description of the Chart component's features is clear and informative.
The change is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-question.json.cn.md (2)
7-7: LGTM!The notice about the Chart component removal and its new import path is clear and informative.
The change is approved.
9-9: LGTM!The description of the Chart component's features is clear and informative.
The change is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-radar.cn.md (2)
7-7: LGTM!The announcement about the future removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The description of the Chart component's features is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-radar.json.cn.md (2)
7-7: LGTM!The announcement about the future removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The description of the Chart component's features is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-ring.cn.md (2)
7-7: LGTM!The announcement about the future removal of the Chart component is clear and informative.
The code changes are approved.
9-9: LGTM!The description of the Chart component's features is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-ring.json.cn.md (2)
7-7: LGTM!The warning about the Chart component's future removal is clear and informative.
The code changes are approved.
9-9: LGTM!The description of the Chart component's features is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-sankey.cn.md (2)
7-7: LGTM!The warning about the Chart component's future removal is clear and informative.
The code changes are approved.
9-9: LGTM!The description of the Chart component's features is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-sankey.json.cn.md (2)
7-7: LGTM!The warning about the Chart component's future removal is clear and informative.
The code changes are approved.
9-9: LGTM!The description of the Chart component's features is clear and informative.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-scatter.cn.md (2)
7-7: LGTM!The warning note is clear and provides essential information about the future changes.
The addition of the warning note is approved.
9-9: LGTM!The expanded description provides valuable information about the component's features.
The addition of the expanded description is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-scatter.json.cn.md (2)
7-7: LGTM!The warning note is clear and provides essential information about the future changes.
The addition of the warning note is approved.
9-9: LGTM!The expanded description provides valuable information about the component's features.
The addition of the expanded description is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-sunburst.cn.md (2)
7-7: LGTM!The warning note is clear and provides essential information about the future changes.
The addition of the warning note is approved.
9-9: LGTM!The expanded description provides valuable information about the component's features.
The addition of the expanded description is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-sunburst.json.cn.md (2)
7-7: LGTM!The warning note about the future removal of the Chart component is clear and informative.
The addition is approved.
9-9: LGTM!The expanded description of the Chart component highlights its features effectively.
The addition is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-tree.cn.md (2)
7-7: LGTM!The warning note about the future removal of the Chart component is clear and informative.
The addition is approved.
9-9: LGTM!The expanded description of the Chart component highlights its features effectively.
The addition is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-tree.json.cn.md (2)
7-7: LGTM!The warning note about the future removal of the Chart component is clear and informative.
The addition is approved.
9-9: LGTM!The expanded description of the Chart component highlights its features effectively.
The addition is approved.
examples/sites/demos/pc/app/chart/webdoc/chart-waterfall.cn.md (3)
7-7: LGTM!The warning about the impending removal of the Chart component is clear and provides important information.
The code changes are approved.
8-8: LGTM!The empty line improves readability by separating different sections of the text.
The code changes are approved.
9-9: LGTM!The description of the Chart component is clear and provides valuable information about its features.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-waterfall.json.cn.md (3)
7-7: LGTM!The warning about the impending removal of the Chart component is clear and provides important information.
The code changes are approved.
8-8: LGTM!The empty line improves readability by separating different sections of the text.
The code changes are approved.
9-9: LGTM!The description of the Chart component is clear and provides valuable information about its features.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-wordcloud.cn.md (3)
7-7: LGTM!The warning about the impending removal of the Chart component is clear and provides important information.
The code changes are approved.
8-8: LGTM!The empty line improves readability by separating different sections of the text.
The code changes are approved.
9-9: LGTM!The description of the Chart component is clear and provides valuable information about its features.
The code changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart-wordcloud.json.cn.md (2)
7-7: LGTM!The announcement about the future of the Chart component is clear and informative.
The changes are approved.
9-9: LGTM!The enhanced description of the Chart component is comprehensive and highlights its key features effectively.
The changes are approved.
examples/sites/demos/pc/app/chart/webdoc/chart.cn.md (2)
7-7: LGTM!The announcement about the future of the Chart component is clear and informative.
The changes are approved.
9-9: LGTM!The enhanced description of the Chart component is comprehensive and highlights its key features effectively.
The changes are approved.
packages/vue/src/chart/chart-candle/src/chart-candle.vue (1)
9-9: LGTM! But verify the consistency of the new import source.The import statement change reflects the renaming of the chart-core packages to huicharts-core. Ensure that the new import source is correct and consistent with the rest of the codebase.
The changes are approved.
Run the following script to verify the consistency of the new import source:
Verification successful
The import source is consistent in
.vuefiles.The import statement
@opentiny/vue-huicharts-coreis consistently used across multiple.vuefiles, indicating that the change is correct within these files. However, due to an error with.tsxfiles, consider manually verifying other file types if needed.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the consistency of the new import source. # Test: Search for the new import source. Expect: Consistent usage across the codebase. rg --type js --type vue --type ts --type tsx --type jsx --type mjs --type cjs --type json '@opentiny/vue-huicharts-core'Length of output: 148
Script:
#!/bin/bash # Description: Verify the consistency of the new import source. # Test: Search for the new import source across relevant file types. rg '@opentiny/vue-huicharts-core' --type js --type ts --type tsx --type jsx --type mjs --type cjs --type json # Manually search for the import in .vue files since rg does not support it directly. fd --extension vue --exec rg '@opentiny/vue-huicharts-core' {}Length of output: 1306
packages/vue/src/chart/chart-boxplot/src/chart-boxplot.vue (1)
9-9: LGTM!The import statement has been correctly updated to
@opentiny/vue-huicharts-core.The code changes are approved.
packages/vue/src/chart/baidu-map/src/baidu-map.vue (2)
10-10: LGTM!The import statement has been correctly updated to
@opentiny/vue-huicharts-core.The code changes are approved.
3-3: LGTM!The formatting adjustment enhances readability without altering the logic or functionality.
The code changes are approved.
packages/vue/src/chart/chart-boxplot/src/boxplot.ts (1)
1-1: LGTM!The import statement has been correctly updated to
@opentiny/vue-huicharts-core.The code changes are approved.
packages/vue/src/chart/chart-bar/src/histogram.ts (1)
1-10: LGTM!The import source change is consistent with the PR objective of renaming the chart-core packages to huicharts-core.
The code changes are approved.
2 participants
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
"AnchorMobileFirst"and"Hooks"to enhance mobile-first design and component lifecycle management.Rebranding
@opentiny/vue-chart-*to@opentiny/vue-huicharts-*, reflecting a unified branding strategy across charting components.Dependency Updates
@opentiny/vue-chart-coreto@opentiny/vue-huicharts-core, ensuring alignment with the new branding.