fix(pager): [pager] add Pager component internationalization #2939
Conversation
WalkthroughThe pull request updates the localization strings for pagination across three language files. In the English file, the exported object's Changes
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
packages/vue-locale/src/lang/es-LA.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/vue-locale/src/lang/en.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. packages/vue-locale/src/lang/pt-BR.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis pull request addresses the internationalization of the Pager component by updating language files for English, Spanish (Latin America), and Portuguese (Brazil). It adds translations for terms like 'page', 'pageClassifier', and 'pagesize', which were previously missing. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
packages/vue-locale/src/lang/en.ts
Outdated
| page: '', | ||
| pageClassifier: '', | ||
| pagesize: '', | ||
| page: 'Article/Page', |
There was a problem hiding this comment.
Ensure that the translation for 'page' and 'pagesize' is contextually appropriate for all usages within the application.
| item: 'elementos', | ||
| next: 'Siguiente', | ||
| page: '', | ||
| page: 'Article/Page', |
There was a problem hiding this comment.
Ensure that the translation for 'page' and 'pagesize' is contextually appropriate for all usages within the application.
| item: 'itens', | ||
| next: 'Próximo', | ||
| page: '', | ||
| page: 'Artigo/Página', |
There was a problem hiding this comment.
Ensure that the translation for 'page' and 'pagesize' is contextually appropriate for all usages within the application.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
packages/vue-locale/src/lang/en.ts (1)
492-494: Consider using more generic pagination terminology.The term 'Article/Page' might not be universally applicable across different contexts where pagination is used (e.g., products, comments, etc.). Consider using more generic terms:
- For
page: "Page"- For
pagesize: "Items per page"- page: 'Article/Page', - pageClassifier: 'page', - pagesize: 'Article/Page', + page: 'Page', + pageClassifier: 'page', + pagesize: 'Items per page',packages/vue-locale/src/lang/pt-BR.ts (1)
496-496: Consider using more generic pagination terminology in Portuguese.Similar to the English translation, consider using more generic terms that would work across different contexts:
- For
page: "Página"- For
pagesize: "Itens por página"- page: 'Artigo/Página', - pagesize: 'Artigo/Página', + page: 'Página', + pagesize: 'Itens por página',Also applies to: 498-498
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
packages/vue-locale/src/lang/en.ts(1 hunks)packages/vue-locale/src/lang/es-LA.ts(1 hunks)packages/vue-locale/src/lang/pt-BR.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: PR E2E Test (pnpm test:e2e3)
| next: 'Próximo', | ||
| page: '', | ||
| page: 'Artigo/Página', | ||
| pageClassifier: '', |
There was a problem hiding this comment.
Add missing translation for pageClassifier.
The pageClassifier property is empty while it's set to 'page' in English. Consider adding the Portuguese translation:
- pageClassifier: '',
+ pageClassifier: 'página',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| pageClassifier: '', | |
| pageClassifier: 'página', |
| item: 'elementos', | ||
| next: 'Siguiente', | ||
| page: '', | ||
| page: 'Article/Page', |
There was a problem hiding this comment.
Replace English text with Spanish translation.
The current text uses English instead of Spanish. Consider using proper Spanish translations:
- For
page: "Página" - For
pagesize: "Elementos por página"
- page: 'Article/Page',
- pagesize: 'Article/Page',
+ page: 'Página',
+ pagesize: 'Elementos por página',Also applies to: 498-498
| next: 'Siguiente', | ||
| page: '', | ||
| page: 'Article/Page', | ||
| pageClassifier: '', |
There was a problem hiding this comment.
Add missing translation for pageClassifier.
The pageClassifier property is empty while it's set to 'page' in English. Consider adding the Spanish translation:
- pageClassifier: '',
+ pageClassifier: 'página',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| pageClassifier: '', | |
| pageClassifier: 'página', |
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit