fix(grid): [grid] resolve incomplete display of table icons

[wuyiping0628]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Style
  • Improved table cell text rendering by refining the conditions under which text ellipsis is applied.
  • Introduced a new styling setting to enhance visual consistency across grid elements, ensuring that expanded cells display content correctly.

[coderabbitai]

Walkthrough

A new variable @grid-cell-prefix is introduced to set a CSS class prefix for grid cells in the LESS file. The .CellEllipsis() mixin is updated so that its selector now excludes span elements with the generated __expanded class, thereby altering which elements receive the text ellipsis and overflow hidden styles.

Changes

File	Summary
packages/theme-saas/src/.../table.less	Added variable @grid-cell-prefix and updated .CellEllipsis() mixin selector to exclude spans with the __expanded class

Sequence Diagram(s)

sequenceDiagram
    participant Element as Grid Cell Element
    participant Mixin as .CellEllipsis() Mixin
    participant CSS as CSS Engine

    Element->>Mixin: Invoke styling evaluation
    Mixin->>CSS: Check for ".tiny-grid-cell-text"
    alt Element has .tiny-grid-cell-text
        CSS-->>Mixin: Omit ellipsis styling
    else Element lacks .tiny-grid-cell-text
        Mixin->>CSS: Verify span is not ".<grid-cell-prefix>__expanded"
        alt Span is not expanded
            CSS-->>Mixin: Apply text ellipsis & overflow hidden
        else Span is expanded
            CSS-->>Mixin: Skip ellipsis styling
        end
    end

Loading

Suggested labels

documentation

Suggested reviewers

• zzcr

Poem

I hopped through code with a joyful stride,
Tweaking styles where secrets reside.
A new prefix in the grid so neat,
Ensures proper ellipsis on each beat.
With carrots of code and leaps so grand,
This rabbit celebrates a CSS wonderland!
🐇🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 985be78 and 85860cd.

📒 Files selected for processing (1)

• packages/theme-saas/src/grid/mixins/table.less (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: PR E2E Test (pnpm test:e2e3)

🔇 Additional comments (2)

packages/theme-saas/src/grid/mixins/table.less (2)

4-4: Addition of new variable @grid-cell-prefix.
This new variable is introduced to dynamically generate the grid prefix for related class names (e.g., in selectors), improving maintainability and consistency across the theme styles. Please double-check that its usage aligns with other prefix variables in the project.

---

38-41: Refined selector in the .CellEllipsis() mixin to exclude expanded cells.
The updated selector now prevents the application of ellipsis and overflow-hidden styles to <span> elements that have the class defined with @{grid-cell-prefix}__expanded. This change is intended to resolve the incomplete display of table icons by ensuring that expanded cells are not inadvertently styled with text truncation. Please ensure thorough testing with various cell states to verify that no side effects occur.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[petercat-assistant]

Walkthrough

This PR addresses an issue with the incomplete display of table icons in the documentation by updating the styling rules in the table.less file. It introduces a new variable for grid cell prefix and modifies the CSS selector to ensure proper text ellipsis behavior.

Changes

File	Summary
packages/theme-saas/src/grid/mixins/table.less	Added a new variable @grid-cell-prefix and updated the CSS selector to fix text ellipsis issues in table headers.

[zzcr]

这个是grid组件不是guide

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

This is grid component, not guide