Skip to content

fix(carousel): [carousel] modify color theme variables #2999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

fix(carousel): [carousel] modify color theme variables #2999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a953da7
fix: modify color theme variables
James-9696 Mar 3, 2025
c89ca96
fix: revise inspection comments
James-9696 Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/theme/src/carousel/index.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
transition-property: none;
transition-timing-function: cubic-bezier(0.16, 0.75, 0.5, 1);
border-radius: var(--tv-Carousel-indicator-active-border-radius);
background-color: var(--tv-Carousel-indicator-active-text-color);
background-color: var(--tv-Carousel-outside-button-active-bg-color);
width: var(--tv-Carousel-indicator-active-button-width);
}

Expand Down
8 changes: 4 additions & 4 deletions packages/theme/src/carousel/vars.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,19 @@
// 幻灯片内的悬浮指示器图标色
--tv-Carousel-indicator-hover-text-color: var(--tv-color-icon-hover);
// 非当前指示器背景色
--tv-Carousel-indicator-button-bg-color: var(--tv-color-bg-gray-2);
--tv-Carousel-indicator-button-bg-color: var(--tv-color-bg-5);
Copy link

@petercat-assistant petercat-assistant bot Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the new theme variable --tv-color-bg-5 is defined and available in the theme configuration to prevent any undefined variable issues.

// 当前指示器右边距
--tv-Carousel-indicator-active-width: 12px;
// 当前指示器背景色
--tv-Carousel-indicator-active-background-color: var(--tv-color-bg-hover-primary);
--tv-Carousel-indicator-active-background-color: var(--tv-color-bg-5-active);
// 当前指示器的宽度
--tv-Carousel-indicator-active-button-width: 12px;
// 当前指示器圆角
--tv-Carousel-indicator-active-border-radius: var(--tv-border-radius-sm);
// 幻灯片外的指示器默认背景色
--tv-Carousel-outside-button-bg-color: #000;
--tv-Carousel-outside-button-bg-color: var(--tv-color-bg-5);
// 幻灯片外的当前指示器背景色
--tv-Carousel-outside-button-active-bg-color: var(--tv-color-bg-hover-primary);
--tv-Carousel-outside-button-active-bg-color: var(--tv-color-bg-5-active);
Copy link

@petercat-assistant petercat-assistant bot Mar 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the new theme variable --tv-color-bg-5-active is defined and available in the theme configuration to prevent any undefined variable issues.

// 标签按钮的字号
--tv-Carousel-labels-button-font-size: var(--tv-font-size-default);
// 箭头悬浮文本颜色
Expand Down