Skip to content

Conversation

@gweesin
Copy link
Contributor

@gweesin gweesin commented Mar 12, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #3116

What is the new behavior?

radio slots can be displayed, and radio mode still work normally

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Enhanced the visual presentation of radio button elements within tree views, resulting in a cleaner and more integrated design.
    • Refined styling and layout details to ensure consistent alignment and improved visual clarity across nested components, delivering a more cohesive user interface.

@coderabbitai
Copy link

coderabbitai bot commented Mar 12, 2025

Walkthrough

The pull request refines the styling of the radio component used within a tree structure. In the LESS file, the generic CSS class is replaced with a more specific nested selector. In the Vue component, a new CSS class is added to the tiny-radio component, modifying its markup. There are no changes to functional logic or control flow.

Changes

File(s) Change Summary
packages/theme/.../index.less, packages/vue/.../tree-node.vue Updated radio component styling: the LESS file now applies a more specific nested selector (&__content-left__radio.@{radio-prefix-cls}) instead of the generic . @{radio-prefix-cls}, and the Vue file adds the new CSS class tiny-tree-node__content-left__radio to the tiny-radio component.

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • zzcr

Poem

I'm a little rabbit, with a skip and a hop,
Tweaking CSS selectors until they perfectly crop.
My ears beat fast with a joyful decree,
Styling radios fine in our tree-view spree.
Carrots and code, together they pop!
🥕🐇

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

 ERR_PNPM_OPTIONAL_DEPS_REQUIRE_PROD_DEPS  Optional dependencies cannot be installed without production dependencies


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c9a00a and baf31b9.

📒 Files selected for processing (2)
  • packages/theme/src/tree/index.less (1 hunks)
  • packages/vue/src/tree/src/tree-node.vue (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (2)
packages/vue/src/tree/src/tree-node.vue (1)

110-118: Good fix! Adding the class correctly connects the radio to its styling.

The added class on the tiny-radio component provides the necessary selector hook for the CSS styles defined in the LESS file. This will ensure that the radio slot is displayed properly while maintaining the desired styling without the label.

packages/theme/src/tree/index.less (1)

463-467: Excellent CSS selector refinement.

The change from a generic selector to a more specific one using &__content-left__radio.@{radio-prefix-cls} properly targets the radio component in the tree node structure. This increased specificity ensures that the styling is correctly applied only to radio elements within the tree node context, resolving the display issue mentioned in the PR objective.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Mar 12, 2025
@petercat-assistant
Copy link

Walkthrough

This pull request addresses a bug where tree node slot radios were not being displayed. The changes ensure that radio slots are now visible while maintaining the normal functionality of radio mode.

Changes

File Summary
packages/theme/src/tree/index.less, packages/vue/src/tree/src/tree-node.vue Adjusted CSS and HTML structure to ensure radio slots are displayed correctly.

@github-actions
Copy link

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

@gweesin gweesin changed the title fix(tree): fix tree node slot radio cannot be displayed fix(tree): [tree] fix tree node slot radio cannot be displayed Mar 12, 2025
@zzcr zzcr linked an issue Mar 12, 2025 that may be closed by this pull request
@zzcr zzcr merged commit 2577616 into opentiny:dev Mar 17, 2025
19 of 21 checks passed
@gweesin gweesin deleted the fix/tree-radio branch March 17, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: 树插槽中使用 tiny-radio-group 文本不显示

2 participants