-
Notifications
You must be signed in to change notification settings - Fork 330
fix(grid): fix grid textarea editor hidden bug #3230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request updates CSS styling in two grid table-related files. In one file, the Changes
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Walkthrough此PR修复了表格中textarea编辑器被截断的问题。通过调整CSS样式,确保编辑器在表格中能够完整显示,避免被截断的情况。 Changes
|
| @apply w-full; | ||
| @apply h-7; | ||
| @apply leading-none; | ||
| @apply h-full; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the height from a fixed value to full height to ensure the textarea editor is not clipped.
WalkthroughThis PR fixes the issue where the textarea editor is truncated in the table. By adjusting the CSS style, ensure that the editor can be displayed in the table in full and avoid truncation. Changes
|
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/theme-saas/src/grid/table.less (1)
1139-1151: Enhance textarea editor styling for full container coverage.The change in the
.@{grid-prefix-cls}-editorblock now appliesh-fullinstead of a fixed height (previouslyh-7), which should resolve the issue of the textarea being truncated. Additionally, removing theleading-noneproperty helps ensure the text inside aligns more naturally with the container’s spacing. Please verify that this change doesn’t adversely affect other components relying on the previous fixed-height style.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
packages/theme-saas/src/grid/table.less(1 hunks)packages/theme/src/grid/table.less(2 hunks)
🔇 Additional comments (1)
packages/theme/src/grid/table.less (1)
978-982: Ensure grid editor fills its container vertically.The updated styling for the
.@{grid-prefix-cls}-editorclass now setsheight: 100%, which replaces the previous variable-based height. This change directly addresses the grid textarea truncation issue by allowing the editor to expand fully. Double-check that the removal of any explicitline-heightsettings does not impact other text elements within the editor.
PR
修复表格textarea编辑器被截断问题
修改前:

修改后:

PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit