Skip to content

fix:[input,steps,loading]fix the style of dark themes #3238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

fix:[input,steps,loading]fix the style of dark themes #3238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/theme/src/input/index.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,14 @@
align-items: center;

svg {
cursor: pointer;
Copy link

@petercat-assistant petercat-assistant bot Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the pointer cursor is appropriate for all interactive elements to enhance user experience.

width: 16px;
height: 16px;
fill: var(--tv-Input-icon-color);

&:hover {
fill: var(--tv-Input-icon-color-hover);
}
}
}

Expand Down
8 changes: 5 additions & 3 deletions packages/theme/src/steps/index.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,8 +380,8 @@
margin-right: 12px;

.icon {
width: var(--tv-Steps-node-circle-size);
height: var(--tv-Steps-node-circle-size);
width: var(--tv-Steps-node-circle-size-lg);
Copy link

@petercat-assistant petercat-assistant bot Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure that the new size variables are correctly applied throughout the component to maintain consistency.

height: var(--tv-Steps-node-circle-size-lg);
}
}
}
Expand Down Expand Up @@ -482,6 +482,7 @@
.@{steps-prefix-cls}-main {
display: flex;
align-items: center;
height: var(--tv-Steps-node-circle-size-lg);
}
}

Expand Down Expand Up @@ -700,6 +701,7 @@
margin-left: var(--tv-Steps-text-margin-left);
font-weight: 500;
padding-top: 2px;
line-height: 1.5;
overflow: hidden;
display: -webkit-box;
-webkit-box-orient: vertical;
Expand Down Expand Up @@ -821,7 +823,7 @@
}

&.large {
.block-size-mixin(32px, 16px, 18px, 16px, 32px, 12px);
.block-size-mixin(40px, 16px, 26px, 16px, 40px, 12px);
}
}

Expand Down
4 changes: 3 additions & 1 deletion packages/theme/src/steps/vars.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,10 @@
--tv-Steps-disabled-icon-color: var(--tv-color-text-disabled, #c2c2c2);
// 描述信息文本色
--tv-Steps-node-desc-text-color: var(--tv-color-text-weaken, #808080);
// 节点圆圈尺寸
// 节点圆圈尺寸-中
--tv-Steps-node-circle-size: var(--tv-size-height-md, 32px);
// 节点圆圈尺寸-large
--tv-Steps-node-circle-size-lg: var(--tv-size-height-lg, 40px);
Copy link

@petercat-assistant petercat-assistant bot Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify that the new large size variable is used consistently across all relevant components.

// 已完成节点边框色
--tv-Steps-node-done-border-color: var(--tv-color-border-active, #191919);
// 已完成节点背景色
Expand Down
31 changes: 15 additions & 16 deletions packages/theme/src/svgs/halfselect.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 0 additions & 4 deletions packages/theme/src/upload-list/index.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,10 +290,6 @@
color: var(--tv-UploadList-item-fail-text-color);
}

&__text-desc {
padding-top: 4px;
}

&__icon-operationfaild {
fill: #f23030;
margin-right: 8px;
Expand Down
Loading