Skip to content

Conversation

@gimmyhehe
Copy link
Member

@gimmyhehe gimmyhehe commented Dec 2, 2025

PR

修复saas主题,input的append内容在form-item内使用出现折行的问题

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Refactor

    • Streamlined parameter usage in grid filter data-retrieval functions.
  • Style

    • Added CSS styling for input group form elements to improve display alignment.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added the bug Something isn't working label Dec 2, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 2, 2025

Walkthrough

Two Vue component files have their getData function signatures simplified by removing unused sort and data parameters, leaving only page and filters. Additionally, a CSS rule is added to the theme styling to apply display: inline-table to elements with combined input and input-group classes.

Changes

Cohort / File(s) Summary
Grid filter server-side parameter cleanup
examples/sites/demos/pc/app/grid/filter/server-filter-composition-api.vue, examples/sites/demos/pc/app/grid/filter/server-filter.vue
Removed unused sort and data parameters from getData function signatures; functions now accept only { page, filters } instead of { page, sort, data, filters }
Theme form-item styling
packages/theme-saas/src/form-item/index.less
Added CSS rule to apply display: inline-table to combined input and input-group class selector

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Parameter removals are straightforward refactoring with no behavioral changes
  • CSS addition is a simple, isolated styling rule
  • Changes are homogeneous and require minimal reasoning per file

Poem

🐰 With parameters trimmed and styles refined,
No clutter remains, just order we'll find,
Filters and pages, inline-table display,
The grid stands cleaner at break of day! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title specifically addresses the main change: fixing input append slot wrapping in form-item within the saas theme. However, the changeset includes unrelated modifications to filter functions (removing parameters from getData methods in two Vue files), making the title only partially representative of all changes in the PR. The title should either be updated to reflect all significant changes (e.g., 'fix(form-item): fix input append slot wrap and clean up getData parameters'), or the unrelated filter function changes should be moved to a separate PR.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cgm/fix-input-append

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c6e5605 and 5ac7193.

📒 Files selected for processing (3)
  • examples/sites/demos/pc/app/grid/filter/server-filter-composition-api.vue (1 hunks)
  • examples/sites/demos/pc/app/grid/filter/server-filter.vue (1 hunks)
  • packages/theme-saas/src/form-item/index.less (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (3)
packages/theme-saas/src/form-item/index.less (1)

199-203: Scoped inline-table override for input-group looks correct

Using .@{input-prefix-cls}.@{input-group-prefix-cls} { @apply inline-table; } under &__content cleanly overrides the base inline-block only for input groups inside form items, which should prevent the append slot wrapping without affecting other inputs.

examples/sites/demos/pc/app/grid/filter/server-filter.vue (1)

109-125: getData signature narrowed to used props; behavior stays consistent

Destructuring only { page, filters } matches what the method actually uses, and any extra fields TinyGrid may pass will be safely ignored, so this is a non-breaking cleanup for the demo. Please just confirm this aligns with the latest fetch-data API shape in TinyGrid’s docs.

examples/sites/demos/pc/app/grid/filter/server-filter-composition-api.vue (1)

102-118: Composition getData cleanup mirrors options demo and is safe

Updating getData to accept only { page, filters } reflects actual usage and keeps this demo consistent with the options-API variant while still accepting any extra fields from TinyGrid. Please verify this matches the documented callback payload for remote filtering.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zzcr zzcr merged commit a5c404e into dev Dec 3, 2025
10 of 11 checks passed
@zzcr zzcr deleted the cgm/fix-input-append branch December 3, 2025 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants