Added support to modify the GLWpfControlSettings within XAML front-end.#106
Merged
NogginBops merged 5 commits intoopentk:masterfrom Apr 27, 2023
mathew-odwyer:feature/public-glwpf-settings
Merged
Added support to modify the GLWpfControlSettings within XAML front-end.#106NogginBops merged 5 commits intoopentk:masterfrom mathew-odwyer:feature/public-glwpf-settings
NogginBops merged 5 commits intoopentk:masterfrom
mathew-odwyer:feature/public-glwpf-settings
Conversation
Member
|
This looks good to me, is there a reason this is WIP? |
Contributor
Author
I believe there was an issue but I can't remember what it was 😂. I'll be getting to this some time today so hopefully we can get it merged :) |
Contributor
Author
|
Lol, I had major and minor version swapped around; fixed now :) |
…ftwareantics/GLWpfControl into feature/public-glwpf-settings
Contributor
Author
|
After testing this out once more; everything seems to be working 😊. If there's anything else I need to do to get this pushed just let me know. |
Member
|
This looks great. I'll merge this now and test it out the next time I do some development on GLWpfControl. Thanks a ton for the PR 🙂 . |
This was referenced Aug 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Startfunction overload that does not take any arguments; it relies on theSettingsattached property.Fixes #105
Dependencies
This PR introduces no new dependencies.
Type of change
How Has This Been Tested?
I tested this locally on my machine and ensured that everything was still functioning as normal within the example project.
Test Configuration:
Proposed Design
Checklist: