Skip to content

Conversation

@evansiroky
Copy link
Contributor

This option allows setting the custom builder function in the config
when creating the reducer’s initial state. When using all of the
reducers together they make calls to the planTrip action, but there
wasn’t really a way to pass in a custom function that way. For now it
seems like the only way to do this could be to set something in the
config of the state.

This PR includes the work done in #12.

also add test case for this function
This option allows setting the custom builder function in the config
when creating the reducer’s initial state.  When using all of the
reducers together they make calls to the planTrip action, but there
wasn’t really a way to pass in a custom function that way.  For now it
seems like the only way to do this could be to set something in the
config of the state.

This PR includes the work done in #12.
@codecov-io
Copy link

codecov-io commented Mar 14, 2017

Codecov Report

Merging #13 into dev will increase coverage by 0.18%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##            dev     #13      +/-   ##
=======================================
+ Coverage   7.2%   7.38%   +0.18%     
=======================================
  Files        34      34              
  Lines       555     555              
=======================================
+ Hits         40      41       +1     
+ Misses      515     514       -1
Impacted Files Coverage Δ
lib/util/state.js 100% <ø> (+14.28%)
lib/actions/api.js 86.36% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dffd054...91fd5ee. Read the comment docs.

@evansiroky evansiroky requested a review from landonreed March 14, 2017 00:20
@evansiroky evansiroky mentioned this pull request Mar 23, 2017
@evansiroky evansiroky merged commit 91fd5ee into dev Mar 23, 2017
@evansiroky evansiroky deleted the custom-otp-query-2 branch March 23, 2017 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants