-
Notifications
You must be signed in to change notification settings - Fork 59
DateTimeSelector from OTP-UI, Remove Profile Routing #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
38673f2
refactor(DateTimeSelector): Replace DateTimeSelector with the one fro…
binh-dam-ibigroup c5904ab
fix(Yarn): Update yarn file; Remove unused stuff in DateTimeModal
binh-dam-ibigroup cf83afd
fix(index): Remove DateTimeSelector from /lib/index.js
binh-dam-ibigroup defce4f
refactor(DateTimeModal): Remove routing profile content.
binh-dam-ibigroup ffd28d8
fix(date-time-modal): Merge from git stash
binh-dam-ibigroup 82a84ae
docs(date-time-modal): Clarify some comments around DateTimeSelector.…
binh-dam-ibigroup 5427bf2
refactor: Merge remote-tracking branch 'origin/dev' into otp-ui-datet…
binh-dam-ibigroup ef82d61
fix(yarn): Revert stuff to fix broken build from previous commit.
binh-dam-ibigroup 9676562
fix(yarn): Fix more broken lint stuff.
binh-dam-ibigroup 374b52f
fix(yarn.lock): Fix broken yarn.lock
binh-dam-ibigroup 45f751a
fix(yarn): Fix yarn.lock /
binh-dam-ibigroup cf0c91b
fix(package.json): Use old pqackage.json see what happens
binh-dam-ibigroup 87a8efb
fix(yarn): Fix yarn so lint doens't complain
binh-dam-ibigroup File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain why we're using props called
*Legacy? This kind of splitting of code paths within the components doesn't seem necessary -- we should not be considering the otp-react-redux project "legacy" software. I don't think I had a chance to review opentripplanner/otp-ui#32, otherwise, I wouldn't have supported the splitting of the handlers like this.EDIT: OK, I'm seeing below that this is intended to support legacy browsers? This and the DateTimeSelector probably need more comments to document this. We may want to modify the prop names to something a little more clear. Without the comment in
mapStateToProps, I would have had little idea what was going on here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree on adding more documentation to
DateTimeSelectorin OTP-ui. There is a tiny bit here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my adjusted the comments that are relevant to OTP-RR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added additional docs on the OTP-UI side, see opentripplanner/otp-ui#98