fix(line-itin/itinerary-body): Use setActiveLeg from NarrativeItineraries #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansiroky
approved these changes
Jul 2, 2020
landonreed
approved these changes
Jul 2, 2020
Member
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
This is OK for now, but the thing we should ultimately do is to change the signature of setActiveLeg and the other actions in narrative-itineraries.js from (index, leg) to ({index, leg}). That probably means some changes in otp-ui too. Please add a comment to that effect in narrative-itineraries and open an issue (if needed) in otp-ui.
Collaborator
Author
|
I have created this OTP-UI issue opentripplanner/otp-ui#180 to coordinate updating the signature of |
Member
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Member
|
🎉 This PR is included in version 1.0.0-alpha.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes the correct version of
setActiveLegtoConnectedItineraryBodyand addresses an issue involving ibi-group/trimet-mod-otp#265.To test: clicking on a leg summary (e.g. "Walk 2 miles to ...") in the current dev will cause a blank screen.
With the proposed changes, the map will zoom to the selected leg.