Skip to content

Do not force ignoreRealtimeUpdates param to true #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2020
Merged

Do not force ignoreRealtimeUpdates param to true #189

merged 1 commit into from
Jul 8, 2020

Conversation

@landonreed
Copy link
Member

@landonreed landonreed commented Jul 7, 2020

Fixes #178.

yarn start
# plan trip
# observe that URL query param ignoreRealtimeUpdates no longer = true

@binh-dam-ibigroup binh-dam-ibigroup removed their assignment Jul 7, 2020
@evansiroky evansiroky assigned landonreed and unassigned evansiroky Jul 8, 2020
@landonreed landonreed merged commit 0eae69c into dev Jul 8, 2020
@landonreed landonreed deleted the fix-ignore-realtime-updates-param branch July 8, 2020 12:35
@landonreed
Copy link
Member Author

landonreed commented Jul 9, 2020

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@landonreed
Copy link
Member Author

landonreed commented Sep 14, 2020

🎉 This PR is included in version 1.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evansiroky evansiroky evansiroky approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@landonreed landonreed

Labels

released on @alpha released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ignoreRealtimeUpdates query param is incorrectly populated with true value

4 participants

@landonreed @evansiroky @binh-dam-ibigroup