Field trip module #230
Merged
Field trip module #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binh-dam-ibigroup
requested changes
Jan 8, 2021
Collaborator
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Some JSDoc need to be updated, and please advise regarding the initial positioning of the Field Trip window.
evansiroky
reviewed
Jan 16, 2021
evansiroky
reviewed
Jan 16, 2021
evansiroky
reviewed
Jan 16, 2021
evansiroky
reviewed
Jan 16, 2021
evansiroky
requested changes
Jan 16, 2021
Contributor
evansiroky
left a comment
evansiroky
left a comment
There was a problem hiding this comment.
Main thing is that the Object type of the field trip details should be implemented. (#230 (comment))
evansiroky
requested changes
Mar 11, 2021
Contributor
evansiroky
left a comment
evansiroky
left a comment
There was a problem hiding this comment.
- Please fix merge conflicts
- Please add code comments in all relevant places with a link to a specific issue or roadmap document explaining why lots of uncommented code has been added and has yet to be implemented (#230 (comment))
- Please add code comments in all relevant places with a link to a specific issue or roadmap document explaining that TriMet-specific code is being added that will eventually need to be configurable for other implementations (#230 (comment))
evansiroky
assigned
binh-dam-ibigroup and
landonreed and unassigned
evansiroky and
binh-dam-ibigroup
evansiroky
approved these changes
Apr 3, 2021
Contributor
evansiroky
left a comment
evansiroky
left a comment
There was a problem hiding this comment.
Approved pending merge conflict resolution
Merged
Contributor
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has been updated to contain the following field trip module functionality:
It does NOT currently have save trip functionality or splitting groups into specific trips. That will come in another PR (because it is very complex).