Update API calls to use pagination endpoint #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evansiroky
approved these changes
Oct 1, 2020
binh-dam-ibigroup
approved these changes
Oct 1, 2020
Collaborator
binh-dam-ibigroup
left a comment
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Approving, and blocking pending merging of ibi-group/otp-middleware#72.
| const { data: trips, status: fetchStatus } = await getTrips(otpMiddleware, accessToken) | ||
| if (fetchStatus === 'success') { | ||
| dispatch(setCurrentUserMonitoredTrips(trips)) | ||
| dispatch(setCurrentUserMonitoredTrips(trips.data)) |
Collaborator
There was a problem hiding this comment.
Maybe rename trips to tripList or something?
Member
Author
|
Merging, now that ibi-group/otp-middleware#72 is merged. |
Member
Author
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates API calls to otp-middleware to bring MOD UI in line with ibi-group/otp-middleware#72.