Form Validation #239
Form Validation #239
Conversation
…f notifs disabled.
| @@ -1,8 +1,8 @@ | |||
| import clone from 'lodash/cloneDeep' | |||
| import { Field, FieldArray } from 'formik' | |||
There was a problem hiding this comment.
I'm just realizing that the amount of files in the lib/components/user directory is getting quite large. Can some subfolders be created to help organize all these files?
There was a problem hiding this comment.
Good point. Perhaps this? In this PR or a separate PR?
user/
- (name needed)
- form-navigation-buttons
- link-button`
- link-menu-item
- stacked-pane-display
- sequential-pane-display
- login
- after-signin-screen
- awaiting-screen
- before-signin-screen
- nav-login-button
- nav-login-button-auth0
- nav-login-button.css
- with-loggedin-user-support
- account
- account-setup-finish-pane.js
- existing-account-display.js
- favorite-locations-pane.js
- new-account-wizard.js
- notification-prefs-pane.js
- phone-verification-pane.js
- terms-of-use-pane.js
- user-account-screen.js
- verify-email-screen.js
- trip
- saved-trip-editor.js
- saved-trip-list.js
- saved-trip-screen.js
- trip-basics-pane.js
- trip-notifications-pane.js
- trip-summary-pane.js
- trip-summary.js
There was a problem hiding this comment.
Might as well do a separate PR. For the (name needed) I'd just keep those in the root /user folder.
| validateOnBlur | ||
| validationSchema={validationSchema} | ||
| onSubmit={isCreating ? this._handleSaveNewTrip : this._handleSaveTripEdits} | ||
| onSubmit={this._handleTrip} |
There was a problem hiding this comment.
I think this is supposed to be _handleSaveTrip (!).
There was a problem hiding this comment.
Wow good catch!
| * Save changes and return to the planner. | ||
| * @param {*} userData The user edited state to be saved, provided by Formik. | ||
| */ | ||
| _handleExitAndSave = async userData => { |
There was a problem hiding this comment.
Minor tweak: could you change this name to _handleSaveAndExit (just to match its behavior)?
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
Looks good. Conditional approval on a couple of handler name changes.
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR converts the forms for user accounts and saved trips into Formik, and adds validation using yup.
Previous form state management code is removed, as all state management is handled by Formik.
The main design change resulting from the Formik conversion is the component change for selecting the monitored trip days.
The following fields are validated: