Encapsulate code to connect LocationField to redux store #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landonreed
requested changes
Dec 9, 2020
Member
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
Looks good. Just a couple of tweaks in #285
refactor(LocationField): refactor HOC for LocationField
| userLocationsAndRecentPlaces: [...user.locations, ...user.recentPlaces] | ||
| } | ||
| // Leave stateToProps.location completely unset unless includeLocation is true. | ||
| if (includeLocation) { |
Collaborator
Author
There was a problem hiding this comment.
@landonreed It is still necessary to leave the location prop unset, otherwise the IntermediatePlaceField and FavoriteLocation components will use the fixed null value as location.
Member
There was a problem hiding this comment.
Ah gotcha, thanks for the info. Could you include that in the comment above?
binh-dam-ibigroup
requested review from
landonreed
and removed request for
landonreed
landonreed
approved these changes
Dec 10, 2020
Member
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
Looks great, just one comment about updating that comment re includeLocation.
Merged
Contributor
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This P demonstrates a way to encapsulate the common code to connect styled
LocationFieldinstances to the redux store.@landonreed let me know what you think of this approach.