Stop viewer/itinerary body status #294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us, various refactors.
… logic in component
landonreed
requested changes
Jan 4, 2021
Member
landonreed
left a comment
landonreed
left a comment
There was a problem hiding this comment.
This generally looks pretty good, but there were some opportunities for encapsulating this logic a bit more into the label component. I was having trouble expressing, so I just made a PR: #296.
refactor(realtime-status-label): encapsulate more of the status label…
landonreed
approved these changes
Jan 5, 2021
evansiroky
reviewed
Jan 26, 2021
Comment on lines
+177
to
+186
| if (delaySeconds > 60) { | ||
| // late departure | ||
| return REALTIME_STATUS.LATE | ||
| } else if (delaySeconds < -60) { | ||
| // early departure | ||
| return REALTIME_STATUS.EARLY | ||
| } else { | ||
| // on-time departure | ||
| return REALTIME_STATUS.ON_TIME | ||
| } |
Contributor
There was a problem hiding this comment.
Consider basing this PR off of #305 and then refactor this function so that it uses the configurable on-time threshold.
Contributor
evansiroky
approved these changes
Jan 26, 2021
evansiroky
added a commit
that referenced
this pull request
Jan 26, 2021
This refactors so that changes from #294 are included.
Merged
Contributor
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in response to #292 (comment) and does the following refactors:
utils/viewerinto a newBaseStatusLabelcomponent.BaseStatusLabelandRealTimeTimeColumn.RealTimeTimeColumnrender code.