-
Notifications
You must be signed in to change notification settings - Fork 58
Refactor Call Taker Panel #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main request is to format times in the date input box according to the configured time format, so as to avoid, for North-American users, what is shown in the screenshot in the PR description. Also consider the formatting changes suggested.
|
@binh-dam-ibigroup thanks for the comments. Just addressed them all in 804d47d. Note that I kept the input value for the time in 24 hr format by default because I think it improves the functioning of the auto-select of the form. The clean time shown in the tooltip has been switched to the config's time format though as suggested. |
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still feel strongly about handling the time input box so we render it in the configured format.
evansiroky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has a merge conflict, so punting back to @landonreed until that is fixed.
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditional approval on tidying up the formatting.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR (be sure to test with calltaker config) does the following high level things: