Skip to content

Conversation

@landonreed
Copy link
Member

@landonreed landonreed commented Jan 7, 2021

This PR (be sure to test with calltaker config) does the following high level things:

  • Reduce call taker panel file size by moving components to their own files (NOTE: the new files are basically unchanged except for date/time and minor changes to the mode selector dropdown)
  • fix date/time functionality and style
    • tooltip on hover shows the actual time (the time input field will interpret various formats)
    • when "now" is selected the time/date will now stay up to date in the form and query params
  • add Uber to Transit and other shared use mode options

image

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main request is to format times in the date input box according to the configured time format, so as to avoid, for North-American users, what is shown in the screenshot in the PR description. Also consider the formatting changes suggested.

@landonreed
Copy link
Member Author

@binh-dam-ibigroup thanks for the comments. Just addressed them all in 804d47d. Note that I kept the input value for the time in 24 hr format by default because I think it improves the functioning of the auto-select of the form. The clean time shown in the tooltip has been switched to the config's time format though as suggested.

Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still feel strongly about handling the time input box so we render it in the configured format.

Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has a merge conflict, so punting back to @landonreed until that is fixed.

@evansiroky evansiroky removed their assignment Jan 27, 2021
@landonreed landonreed assigned evansiroky and unassigned landonreed Jan 28, 2021
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval on tidying up the formatting.

@landonreed landonreed removed their assignment Feb 1, 2021
@landonreed landonreed merged commit 3ca9b26 into dev Feb 1, 2021
@landonreed landonreed deleted the refactor-call-taker-panel branch February 1, 2021 21:00
@evansiroky evansiroky mentioned this pull request Mar 31, 2021
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants